From 8b353fbf66aed77eef2c96c4660b0c0477fc14fa Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sun, 2 Mar 2025 17:01:36 +0100
Subject: [PATCH] Feature/introduce Promise.all() in getPerformance() of
 portfolio service (#4381)

* Introduce Promise.all()

* Update changelog
---
 CHANGELOG.md                                    |  1 +
 apps/api/src/app/portfolio/portfolio.service.ts | 13 ++++++-------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e1adcd3ba..292232754 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Optimized the asynchronous operations using `Promise.all()` in the portfolio service (`getPerformance`)
 - Improved the symbol lookup in the _Trackinsight_ data enhancer for asset profile data
 
 ### Fixed
diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts
index d4dc42d91..ce03c8024 100644
--- a/apps/api/src/app/portfolio/portfolio.service.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.ts
@@ -1081,19 +1081,18 @@ export class PortfolioService {
     const user = await this.userService.user({ id: userId });
     const userCurrency = this.getUserCurrency(user);
 
-    const accountBalanceItems =
-      await this.accountBalanceService.getAccountBalanceItems({
+    const [accountBalanceItems, { activities }] = await Promise.all([
+      this.accountBalanceService.getAccountBalanceItems({
         filters,
         userId,
         userCurrency
-      });
-
-    const { activities } =
-      await this.orderService.getOrdersForPortfolioCalculator({
+      }),
+      this.orderService.getOrdersForPortfolioCalculator({
         filters,
         userCurrency,
         userId
-      });
+      })
+    ]);
 
     if (accountBalanceItems.length === 0 && activities.length === 0) {
       return {