From 8be4f3c693272419e274cfa96ef4b837f57a5c7d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Germ=C3=A1n=20Mart=C3=ADn?= <github@gmartin.net>
Date: Sat, 11 Oct 2025 00:31:51 +0200
Subject: [PATCH] refactor: remove disabled binding from portfolio filter form
 and streamline tag control logic

---
 libs/ui/src/lib/assistant/assistant.html                     | 1 -
 .../portfolio-filter-form/portfolio-filter-form.component.ts | 5 ++++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/libs/ui/src/lib/assistant/assistant.html b/libs/ui/src/lib/assistant/assistant.html
index f62e86029..f073c3444 100644
--- a/libs/ui/src/lib/assistant/assistant.html
+++ b/libs/ui/src/lib/assistant/assistant.html
@@ -185,7 +185,6 @@
         #portfolioFilterForm
         [accounts]="user?.accounts"
         [assetClasses]="assetClasses"
-        [disabled]="!hasPermissionToChangeFilters"
         [formControl]="portfolioFilterFormControl"
         [holdings]="holdings"
         [tags]="tags"
diff --git a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts
index 514a8ba7f..beb7dc56f 100644
--- a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts
+++ b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts
@@ -124,8 +124,11 @@ export class GfPortfolioFilterFormComponent
       this.filterForm.enable({ emitEvent: false });
     }
 
+    const tagControl = this.filterForm.get('tag');
     if (this.tags.length === 0) {
-      this.filterForm.get('tag')?.disable({ emitEvent: false });
+      tagControl?.disable({ emitEvent: false });
+    } else if (!this.disabled) {
+      tagControl?.enable({ emitEvent: false });
     }
 
     this.changeDetectorRef.markForCheck();