From 8bf49542767bfb1716491294f2955546918ef5bd Mon Sep 17 00:00:00 2001 From: Thomas <4159106+dtslvr@users.noreply.github.com> Date: Sun, 30 Apr 2023 11:47:57 +0200 Subject: [PATCH] Add guards --- apps/api/src/app/portfolio/portfolio.service.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts index 1b839977b..3536169f2 100644 --- a/apps/api/src/app/portfolio/portfolio.service.ts +++ b/apps/api/src/app/portfolio/portfolio.service.ts @@ -466,9 +466,10 @@ export class PortfolioService { cashDetails.balanceInBaseCurrency ); - const isFilteredByAccount = filters.some((filter) => { - return filter.type === 'ACCOUNT'; - }); + const isFilteredByAccount = + filters?.some((filter) => { + return filter.type === 'ACCOUNT'; + }) ?? false; let filteredValueInBaseCurrency = isFilteredByAccount ? totalValueInBaseCurrency @@ -571,11 +572,11 @@ export class PortfolioService { }; } - const isFilteredByCash = filters.some((filter) => { + const isFilteredByCash = filters?.some((filter) => { return filter.type === 'ASSET_CLASS' && filter.id === 'CASH'; }); - if (filters.length === 0 || isFilteredByCash || isFilteredByAccount) { + if (filters?.length === 0 || isFilteredByAccount || isFilteredByCash) { const cashPositions = await this.getCashPositions({ cashDetails, userCurrency,