Fix positive performance from all time high

apps/api/src/app/endpoints/watchlist/watchlist.service.ts

@@ -142,7 +142,9 @@ export class WatchlistService {
             allTimeHigh: {
               date: allTimeHigh?.date,
               performancePercent:
-                performancePercent >= 0 ? 0 : performancePercent
+                this.benchmarkService.getPerformancePercentFromAllTimeHigh(
+                  performancePercent
+                )
             }
           },
           trend50d: trends.trend50d,

apps/api/src/services/benchmark/benchmark.service.spec.ts

@@ -24,4 +24,14 @@ describe('BenchmarkService', () => {
     );
     expect(benchmarkService.getMarketCondition(-0.2)).toEqual('BEAR_MARKET');
   });
+
+  it('getPerformancePercentFromAllTimeHigh', async () => {
+    expect(benchmarkService.getPerformancePercentFromAllTimeHigh(0.1)).toEqual(
+      0
+    );
+    expect(benchmarkService.getPerformancePercentFromAllTimeHigh(0)).toEqual(0);
+    expect(benchmarkService.getPerformancePercentFromAllTimeHigh(-0.1)).toEqual(
+      -0.1
+    );
+  });
 });

apps/api/src/services/benchmark/benchmark.service.ts

@@ -216,6 +216,12 @@ export class BenchmarkService {
     }
   }
 
+  public getPerformancePercentFromAllTimeHigh(performancePercent: number) {
+    const isAtAllTimeHigh = performancePercent >= 0;
+
+    return isAtAllTimeHigh ? 0 : performancePercent;
+  }
+
   public async isBenchmark(symbolProfileId: string): Promise<boolean> {
     const benchmarks = await this.getBenchmarksProperty();
 
@@ -288,10 +294,9 @@ export class BenchmarkService {
         performances: {
           allTimeHigh: {
             date: allTimeHigh?.date,
-            performancePercent:
-              performancePercentFromAllTimeHigh >= 0
-                ? 0
-                : performancePercentFromAllTimeHigh
+            performancePercent: this.getPerformancePercentFromAllTimeHigh(
+              performancePercentFromAllTimeHigh
+            )
           }
         },
         symbol: benchmarkAssetProfiles[index].symbol,