From 9220a353e9fd996ac34483cac012db5368d95c00 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Fri, 31 Jul 2026 08:46:53 +0200 Subject: [PATCH] Improve search log output for unsupported queries --- .../data-providers/ghostfolio/ghostfolio.service.ts | 6 +----- .../services/data-provider/data-provider.service.ts | 2 +- .../yahoo-finance/yahoo-finance.service.ts | 10 +++++----- .../symbol-autocomplete.component.ts | 4 ++-- 4 files changed, 9 insertions(+), 13 deletions(-) diff --git a/apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.service.ts b/apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.service.ts index 5dd5f444ed..463ccf2098 100644 --- a/apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.service.ts +++ b/apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.service.ts @@ -342,7 +342,7 @@ export class GhostfolioService { query = query?.trim(); - if (!query) { + if (!query || query.length < 2) { return results; } @@ -350,10 +350,6 @@ export class GhostfolioService { let lookupItems: LookupItem[] = []; const promises: Promise<{ items: LookupItem[] }>[] = []; - if (query?.length < 2) { - return { items: lookupItems }; - } - for (const dataProviderService of this.getDataProviderServices()) { promises.push( dataProviderService.search({ diff --git a/apps/api/src/services/data-provider/data-provider.service.ts b/apps/api/src/services/data-provider/data-provider.service.ts index cea8f0fc94..1ee4faa794 100644 --- a/apps/api/src/services/data-provider/data-provider.service.ts +++ b/apps/api/src/services/data-provider/data-provider.service.ts @@ -840,7 +840,7 @@ export class DataProviderService implements OnModuleInit { query = query?.trim(); - if (query?.length < 2) { + if (!query || query.length < 2) { return { items: lookupItems }; } diff --git a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts index 818eb8fa4a..352e912381 100644 --- a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts +++ b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts @@ -330,13 +330,13 @@ export class YahooFinanceService implements DataProviderInterface { }); } } catch (error) { - let message = error; - if (error?.name === 'BadRequestError') { - message = `RequestError: The search for "${query}" is not supported`; + this.logger.warn( + `The search for "${query}" is not supported: ${error.message}` + ); + } else { + this.logger.error(error); } - - this.logger.error(message); } return { items }; diff --git a/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts b/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts index 1626ff2f20..704c4ed446 100644 --- a/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts +++ b/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts @@ -141,13 +141,13 @@ export class GfSymbolAutocompleteComponent return isString(query); }), + debounceTime(400), + distinctUntilChanged(), tap(() => { this.isLoading = true; this.changeDetectorRef.markForCheck(); }), - debounceTime(400), - distinctUntilChanged(), takeUntilDestroyed(this.destroyRef), switchMap((query: string) => { return this.dataService.fetchSymbols({