Browse Source

rename hasHistoricalData to canHandle

pull/123/head
Valentin Zickner 4 years ago
parent
commit
931bfb997f
  1. 2
      apps/api/src/services/data-provider.service.ts
  2. 2
      apps/api/src/services/data-provider/alpha-vantage/alpha-vantage.service.ts
  3. 2
      apps/api/src/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service.ts
  4. 14
      apps/api/src/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service.ts
  5. 8
      apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts
  6. 2
      apps/api/src/services/interfaces/data-provider.interface.ts

2
apps/api/src/services/data-provider.service.ts

@ -136,7 +136,7 @@ export class DataProviderService implements DataProviderInterface {
}>[] = []; }>[] = [];
for (const { dataSource, symbol } of aDataGatheringItems) { for (const { dataSource, symbol } of aDataGatheringItems) {
const dataProvider = this.getDataProvider(dataSource); const dataProvider = this.getDataProvider(dataSource);
if (dataProvider.hasHistoricalData(symbol)) { if (dataProvider.canHandle(symbol)) {
promises.push( promises.push(
dataProvider dataProvider
.getHistorical([symbol], undefined, from, to) .getHistorical([symbol], undefined, from, to)

2
apps/api/src/services/data-provider/alpha-vantage/alpha-vantage.service.ts

@ -24,7 +24,7 @@ export class AlphaVantageService implements DataProviderInterface {
}); });
} }
public hasHistoricalData(symbol: string) { public canHandle(symbol: string) {
return this.configurationService.get('ALPHA_VANTAGE_API_KEY'); return this.configurationService.get('ALPHA_VANTAGE_API_KEY');
} }

2
apps/api/src/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service.ts

@ -24,7 +24,7 @@ export class GhostfolioScraperApiService implements DataProviderInterface {
public constructor(private prisma: PrismaService) {} public constructor(private prisma: PrismaService) {}
public hasHistoricalData(symbol: string) { public canHandle(symbol: string) {
return isGhostfolioScraperApiSymbol(symbol); return isGhostfolioScraperApiSymbol(symbol);
} }

14
apps/api/src/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service.ts

@ -28,6 +28,13 @@ export class RakutenRapidApiService implements DataProviderInterface {
private readonly configurationService: ConfigurationService private readonly configurationService: ConfigurationService
) {} ) {}
public canHandle(symbol: string) {
return (
isRakutenRapidApiSymbol(symbol) &&
this.configurationService.get('RAKUTEN_RAPID_API_KEY')
);
}
public async get( public async get(
aSymbols: string[] aSymbols: string[]
): Promise<{ [symbol: string]: IDataProviderResponse }> { ): Promise<{ [symbol: string]: IDataProviderResponse }> {
@ -58,13 +65,6 @@ export class RakutenRapidApiService implements DataProviderInterface {
return {}; return {};
} }
public hasHistoricalData(symbol: string) {
return (
isRakutenRapidApiSymbol(symbol) &&
this.configurationService.get('RAKUTEN_RAPID_API_KEY')
);
}
public async getHistorical( public async getHistorical(
aSymbols: string[], aSymbols: string[],
aGranularity: Granularity = 'day', aGranularity: Granularity = 'day',

8
apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts

@ -28,6 +28,10 @@ export class YahooFinanceService implements DataProviderInterface {
public constructor() {} public constructor() {}
public canHandle(symbol: string) {
return true;
}
public async get( public async get(
aSymbols: string[] aSymbols: string[]
): Promise<{ [symbol: string]: IDataProviderResponse }> { ): Promise<{ [symbol: string]: IDataProviderResponse }> {
@ -90,10 +94,6 @@ export class YahooFinanceService implements DataProviderInterface {
} }
} }
public hasHistoricalData(symbol: string) {
return true;
}
public async getHistorical( public async getHistorical(
aSymbols: string[], aSymbols: string[],
aGranularity: Granularity = 'day', aGranularity: Granularity = 'day',

2
apps/api/src/services/interfaces/data-provider.interface.ts

@ -7,7 +7,7 @@ import {
} from './interfaces'; } from './interfaces';
export interface DataProviderInterface { export interface DataProviderInterface {
hasHistoricalData(symbol: string): boolean; canHandle(symbol: string): boolean;
get(aSymbols: string[]): Promise<{ [symbol: string]: IDataProviderResponse }>; get(aSymbols: string[]): Promise<{ [symbol: string]: IDataProviderResponse }>;

Loading…
Cancel
Save