From 93f49bfe10c009bcc8bcf610642a7ef1247fd902 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sat, 9 Mar 2024 10:35:38 +0100
Subject: [PATCH] Refactoring

---
 .../exchange-rate-data/exchange-rate-data.service.ts  | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts b/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts
index 6a01c5184..a02ddb597 100644
--- a/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts
+++ b/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts
@@ -73,14 +73,17 @@ export class ExchangeRateDataService {
           currencyTo: targetCurrency
         });
 
-      const keys = Object.keys(
+      const dateStrings = Object.keys(
         exchangeRatesByCurrency[`${currency}${targetCurrency}`]
       );
-      const lastDate = keys.reduce((a, b) => (a > b ? a : b));
+      const lastDateString = dateStrings.reduce((a, b) => {
+        return a > b ? a : b;
+      });
 
       let previousExchangeRate =
-        exchangeRatesByCurrency[`${currency}${targetCurrency}`]?.[lastDate] ??
-        1;
+        exchangeRatesByCurrency[`${currency}${targetCurrency}`]?.[
+          lastDateString
+        ] ?? 1;
 
       // Start from the most recent date and fill in missing exchange rates
       // using the latest available rate