From 94756b6210da0b68af55c66664d8dafe4edd5436 Mon Sep 17 00:00:00 2001 From: waxif Date: Sat, 19 Oct 2024 21:52:27 +0400 Subject: [PATCH] Removed the empty constructors Reverted implements OnInit on required classes 1. Removed from all classes public ngOnInit() {} 2. Removed ngOnInit() method from all files 3. Removed the OnInit interface from the classes 4. Removed the OnInit import from the top of all files --- .../src/app/components/dialog-footer/dialog-footer.component.ts | 2 +- .../src/app/components/dialog-header/dialog-header.component.ts | 2 +- .../fear-and-greed-index/fear-and-greed-index.component.ts | 2 +- .../components/portfolio-summary/portfolio-summary.component.ts | 2 +- apps/client/src/app/components/toggle/toggle.component.ts | 2 +- .../app/pages/faq/self-hosting/self-hosting-page.component.ts | 2 +- apps/client/src/app/pages/i18n/i18n-page.component.ts | 2 +- apps/client/src/app/pages/markets/markets-page.component.ts | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/apps/client/src/app/components/dialog-footer/dialog-footer.component.ts b/apps/client/src/app/components/dialog-footer/dialog-footer.component.ts index 3f9b32ae0..ad7eb80ea 100644 --- a/apps/client/src/app/components/dialog-footer/dialog-footer.component.ts +++ b/apps/client/src/app/components/dialog-footer/dialog-footer.component.ts @@ -18,7 +18,7 @@ export class DialogFooterComponent { @Output() closeButtonClicked = new EventEmitter(); - public constructor() {} + public onClickCloseButton() { this.closeButtonClicked.emit(); diff --git a/apps/client/src/app/components/dialog-header/dialog-header.component.ts b/apps/client/src/app/components/dialog-header/dialog-header.component.ts index 646098805..7ea9c2979 100644 --- a/apps/client/src/app/components/dialog-header/dialog-header.component.ts +++ b/apps/client/src/app/components/dialog-header/dialog-header.component.ts @@ -20,7 +20,7 @@ export class DialogHeaderComponent { @Output() closeButtonClicked = new EventEmitter(); - public constructor() {} + public onClickCloseButton() { this.closeButtonClicked.emit(); diff --git a/apps/client/src/app/components/fear-and-greed-index/fear-and-greed-index.component.ts b/apps/client/src/app/components/fear-and-greed-index/fear-and-greed-index.component.ts index c5bbcb23c..d2ba7c5f0 100644 --- a/apps/client/src/app/components/fear-and-greed-index/fear-and-greed-index.component.ts +++ b/apps/client/src/app/components/fear-and-greed-index/fear-and-greed-index.component.ts @@ -20,7 +20,7 @@ export class FearAndGreedIndexComponent implements OnChanges{ public fearAndGreedIndexEmoji: string; public fearAndGreedIndexText: string; - public constructor() {} + public ngOnChanges() { const { emoji, key } = resolveFearAndGreedIndex(this.fearAndGreedIndex); diff --git a/apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts b/apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts index 2d7c695db..49d19a5d6 100644 --- a/apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts +++ b/apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts @@ -34,7 +34,7 @@ export class PortfolioSummaryComponent implements OnChanges{ ); public timeInMarket: string; - public constructor() {} + public ngOnChanges() { if (this.summary) { diff --git a/apps/client/src/app/components/toggle/toggle.component.ts b/apps/client/src/app/components/toggle/toggle.component.ts index 0434564f1..e90649e0f 100644 --- a/apps/client/src/app/components/toggle/toggle.component.ts +++ b/apps/client/src/app/components/toggle/toggle.component.ts @@ -33,7 +33,7 @@ export class ToggleComponent implements OnChanges{ public optionFormControl = new FormControl(undefined); - public constructor() {} + public ngOnChanges() { this.optionFormControl.setValue(this.defaultValue); diff --git a/apps/client/src/app/pages/faq/self-hosting/self-hosting-page.component.ts b/apps/client/src/app/pages/faq/self-hosting/self-hosting-page.component.ts index 49626f94c..4180c527e 100644 --- a/apps/client/src/app/pages/faq/self-hosting/self-hosting-page.component.ts +++ b/apps/client/src/app/pages/faq/self-hosting/self-hosting-page.component.ts @@ -10,7 +10,7 @@ import { Subject } from 'rxjs'; export class SelfHostingPageComponent implements OnDestroy { private unsubscribeSubject = new Subject(); - public constructor() {} + public ngOnDestroy() { this.unsubscribeSubject.next(); diff --git a/apps/client/src/app/pages/i18n/i18n-page.component.ts b/apps/client/src/app/pages/i18n/i18n-page.component.ts index 259fff725..ae8c4fb93 100644 --- a/apps/client/src/app/pages/i18n/i18n-page.component.ts +++ b/apps/client/src/app/pages/i18n/i18n-page.component.ts @@ -11,7 +11,7 @@ import { Subject } from 'rxjs'; export class GfI18nPageComponent { private unsubscribeSubject = new Subject(); - public constructor() {} + public ngOnDestroy() { this.unsubscribeSubject.next(); diff --git a/apps/client/src/app/pages/markets/markets-page.component.ts b/apps/client/src/app/pages/markets/markets-page.component.ts index d3f650038..dd392342d 100644 --- a/apps/client/src/app/pages/markets/markets-page.component.ts +++ b/apps/client/src/app/pages/markets/markets-page.component.ts @@ -10,7 +10,7 @@ import { Subject } from 'rxjs'; export class MarketsPageComponent implements OnDestroy{ private unsubscribeSubject = new Subject(); - public constructor() {} + public ngOnDestroy() { this.unsubscribeSubject.next();