Browse Source
Bugfix/fix spike of positions with differing currency of user (#248)
* Convert market price back to currency of position
* Update changelog
pull/254/head
Thomas
4 years ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with
8 additions and
1 deletions
-
CHANGELOG.md
-
apps/api/src/app/portfolio/portfolio.service.ts
|
|
@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
### Fixed |
|
|
|
|
|
|
|
- Fixed the missing market state in the positions tab |
|
|
|
- Fixed the chart of positions with differing currency from user |
|
|
|
|
|
|
|
## 1.31.1 - 01.08.2021 |
|
|
|
|
|
|
|
|
|
@ -300,11 +300,17 @@ export class PortfolioService { |
|
|
|
currency, |
|
|
|
firstBuyDate, |
|
|
|
investment, |
|
|
|
marketPrice, |
|
|
|
quantity, |
|
|
|
transactionCount |
|
|
|
} = position; |
|
|
|
|
|
|
|
// Convert market price back to currency of position
|
|
|
|
const marketPrice = this.exchangeRateDataService.toCurrency( |
|
|
|
position.marketPrice, |
|
|
|
this.request.user.Settings.currency, |
|
|
|
currency |
|
|
|
); |
|
|
|
|
|
|
|
const historicalData = await this.dataProviderService.getHistorical( |
|
|
|
[aSymbol], |
|
|
|
'day', |
|
|
|