Browse Source

Code review fixes

pull/4350/head
csehatt741 3 months ago
committed by Thomas Kaul
parent
commit
972681f161
  1. 5
      apps/api/src/app/portfolio/calculator/portfolio-calculator.ts
  2. 2
      apps/api/src/app/portfolio/calculator/twr/portfolio-calculator.ts

5
apps/api/src/app/portfolio/calculator/portfolio-calculator.ts

@ -175,12 +175,9 @@ export abstract class PortfolioCalculator {
if (!transactionPoints.length) { if (!transactionPoints.length) {
return { return {
<<<<<<< HEAD
activitiesCount: 0, activitiesCount: 0,
=======
>>>>>>> 6e5db62f (Code review fixes)
currentValueInBaseCurrency: new Big(0),
createdAt: new Date(), createdAt: new Date(),
currentValueInBaseCurrency: new Big(0),
errors: [], errors: [],
hasErrors: false, hasErrors: false,
historicalData: [], historicalData: [],

2
apps/api/src/app/portfolio/calculator/twr/portfolio-calculator.ts

@ -104,8 +104,8 @@ export class TWRPortfolioCalculator extends PortfolioCalculator {
activitiesCount: this.activities.filter(({ type }) => { activitiesCount: this.activities.filter(({ type }) => {
return ['BUY', 'SELL'].includes(type); return ['BUY', 'SELL'].includes(type);
}).length, }).length,
errors: [],
createdAt: new Date(), createdAt: new Date(),
errors: [],
historicalData: [], historicalData: [],
totalLiabilitiesWithCurrencyEffect: new Big(0), totalLiabilitiesWithCurrencyEffect: new Big(0),
totalValuablesWithCurrencyEffect: new Big(0) totalValuablesWithCurrencyEffect: new Big(0)

Loading…
Cancel
Save