Browse Source

Feature/switch prefer-function-type eslint rule from warn to error (#3981)

* Switch prefer-function-type eslint rule from warn to error

* Update changelog

---------

Signed-off-by: Dominik Willner <th33xitus@gmail.com>
pull/3987/head^2
dw-0 3 months ago
committed by GitHub
parent
commit
9a885e821e
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 1
      .eslintrc.json
  2. 1
      CHANGELOG.md
  3. 2
      apps/client/src/app/util/form.util.ts

1
.eslintrc.json

@ -142,7 +142,6 @@
// The following rules are part of @typescript-eslint/stylistic-type-checked
// and can be remove once solved
"@typescript-eslint/prefer-function-type": "warn",
"@typescript-eslint/prefer-nullish-coalescing": "warn", // TODO: Requires strictNullChecks: true
"@typescript-eslint/consistent-type-assertions": "warn",
"@typescript-eslint/prefer-optional-chain": "warn",

1
CHANGELOG.md

@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Switched the `consistent-type-definitions` rule from `warn` to `error` in the `eslint` configuration
- Switched the `no-empty-function` rule from `warn` to `error` in the `eslint` configuration
- Switched the `prefer-function-type` rule from `warn` to `error` in the `eslint` configuration
### Fixed

2
apps/client/src/app/util/form.util.ts

@ -8,7 +8,7 @@ export async function validateObjectForForm<T>({
ignoreFields = [],
object
}: {
classDto: { new (): T };
classDto: new () => T;
form: FormGroup;
ignoreFields?: string[];
object: T;

Loading…
Cancel
Save