From 9cbf789c22fe8e956296bc751a30bfc412a6c5f6 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Tue, 7 Sep 2021 22:11:38 +0200
Subject: [PATCH] Bugfix/fix values in position detail dialog (#351)

* Nullify netPerformance

* Introduce precision

* Update changelog
---
 CHANGELOG.md                                    | 10 ++++++++++
 .../src/app/portfolio/portfolio.controller.ts   |  1 +
 .../position-detail-dialog.html                 |  5 ++---
 libs/ui/.eslintrc.json                          |  4 ++--
 .../ui/src/lib/value/value.component.stories.ts | 17 ++++++++---------
 libs/ui/src/lib/value/value.component.ts        | 10 ++++++----
 6 files changed, 29 insertions(+), 18 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 85bc85855..4936a5b71 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+
+### Added
+
+- Added the attribute `precision` in the value component
+
+### Fixed
+
+- Hid the performance in the _Presenter View_
+
 ## 1.47.1 - 06.09.2021
 
 ### Fixed
diff --git a/apps/api/src/app/portfolio/portfolio.controller.ts b/apps/api/src/app/portfolio/portfolio.controller.ts
index 34e7d5376..e2cf73614 100644
--- a/apps/api/src/app/portfolio/portfolio.controller.ts
+++ b/apps/api/src/app/portfolio/portfolio.controller.ts
@@ -276,6 +276,7 @@ export class PortfolioController {
         position = nullifyValuesInObject(position, [
           'grossPerformance',
           'investment',
+          'netPerformance',
           'quantity'
         ]);
       }
diff --git a/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html b/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
index 1847676f4..939f0f4dc 100644
--- a/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
+++ b/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
@@ -80,7 +80,8 @@
         <gf-value
           label="Quantity"
           size="medium"
-          [isCurrency]="true"
+          [locale]="data.locale"
+          [precision]="2"
           [value]="quantity"
         ></gf-value>
       </div>
@@ -103,8 +104,6 @@
       <div class="col-6 mb-3">
         <gf-value
           size="medium"
-          [isCurrency]="false"
-          [isInteger]="true"
           [label]="transactionCount === 1 ? 'Transaction' : 'Transactions'"
           [locale]="data.locale"
           [value]="transactionCount"
diff --git a/libs/ui/.eslintrc.json b/libs/ui/.eslintrc.json
index 7b1712f15..80487666a 100644
--- a/libs/ui/.eslintrc.json
+++ b/libs/ui/.eslintrc.json
@@ -13,7 +13,7 @@
           "error",
           {
             "type": "attribute",
-            "prefix": "ghostfolio",
+            "prefix": "gf",
             "style": "camelCase"
           }
         ],
@@ -21,7 +21,7 @@
           "error",
           {
             "type": "element",
-            "prefix": "ghostfolio",
+            "prefix": "gf",
             "style": "kebab-case"
           }
         ]
diff --git a/libs/ui/src/lib/value/value.component.stories.ts b/libs/ui/src/lib/value/value.component.stories.ts
index f11eb256e..8cd585de9 100644
--- a/libs/ui/src/lib/value/value.component.stories.ts
+++ b/libs/ui/src/lib/value/value.component.stories.ts
@@ -29,17 +29,16 @@ Currency.args = {
   value: 7
 };
 
-export const Integer = Template.bind({});
-Integer.args = {
-  isInteger: true,
-  locale: 'en-US',
-  value: 7
-};
-
 export const Label = Template.bind({});
 Label.args = {
-  isInteger: true,
   label: 'Label',
   locale: 'en-US',
-  value: 7
+  value: 7.25
+};
+
+export const Precision = Template.bind({});
+Precision.args = {
+  locale: 'en-US',
+  precision: 3,
+  value: 7.2534802394809285309
 };
diff --git a/libs/ui/src/lib/value/value.component.ts b/libs/ui/src/lib/value/value.component.ts
index 869392003..fbe6c2878 100644
--- a/libs/ui/src/lib/value/value.component.ts
+++ b/libs/ui/src/lib/value/value.component.ts
@@ -18,11 +18,11 @@ export class ValueComponent implements OnChanges {
   @Input() colorizeSign = false;
   @Input() currency = '';
   @Input() isCurrency = false;
-  @Input() isInteger = false;
   @Input() isPercent = false;
   @Input() label = '';
   @Input() locale = '';
   @Input() position = '';
+  @Input() precision: number | undefined;
   @Input() size = '';
   @Input() value: number | string = '';
 
@@ -82,13 +82,15 @@ export class ValueComponent implements OnChanges {
               minimumFractionDigits: 2
             });
           } catch {}
-        } else if (this.isInteger) {
+        } else if (this.precision || this.precision === 0) {
           try {
             this.formattedValue = this.value?.toLocaleString(this.locale, {
-              maximumFractionDigits: 0,
-              minimumFractionDigits: 0
+              maximumFractionDigits: this.precision,
+              minimumFractionDigits: this.precision
             });
           } catch {}
+        } else {
+          this.formattedValue = this.value?.toString();
         }
       } else {
         try {