From 9e5d4a703a1b406d20431e02e4581bcda0f7fc69 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sat, 12 Oct 2024 20:51:22 +0200
Subject: [PATCH] Refactoring

---
 .../src/models/rules/account-cluster-risk/single-account.ts | 2 +-
 .../base-currency-current-investment.ts                     | 2 +-
 .../src/models/rules/emergency-fund/emergency-fund-setup.ts | 2 +-
 apps/client/src/app/components/rule/rule.component.html     | 6 +-----
 4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/apps/api/src/models/rules/account-cluster-risk/single-account.ts b/apps/api/src/models/rules/account-cluster-risk/single-account.ts
index 22e789041..ef549e579 100644
--- a/apps/api/src/models/rules/account-cluster-risk/single-account.ts
+++ b/apps/api/src/models/rules/account-cluster-risk/single-account.ts
@@ -35,7 +35,7 @@ export class AccountClusterRiskSingleAccount extends Rule<RuleSettings> {
   }
 
   public getConfiguration() {
-    return {};
+    return undefined;
   }
 
   public getSettings({ xRayRules }: UserSettings): RuleSettings {
diff --git a/apps/api/src/models/rules/currency-cluster-risk/base-currency-current-investment.ts b/apps/api/src/models/rules/currency-cluster-risk/base-currency-current-investment.ts
index d5b586cdc..573795799 100644
--- a/apps/api/src/models/rules/currency-cluster-risk/base-currency-current-investment.ts
+++ b/apps/api/src/models/rules/currency-cluster-risk/base-currency-current-investment.ts
@@ -62,7 +62,7 @@ export class CurrencyClusterRiskBaseCurrencyCurrentInvestment extends Rule<Setti
   }
 
   public getConfiguration() {
-    return {};
+    return undefined;
   }
 
   public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings {
diff --git a/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts b/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts
index 3f5d65def..d13f2ffc5 100644
--- a/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts
+++ b/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts
@@ -33,7 +33,7 @@ export class EmergencyFundSetup extends Rule<Settings> {
   }
 
   public getConfiguration() {
-    return {};
+    return undefined;
   }
 
   public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings {
diff --git a/apps/client/src/app/components/rule/rule.component.html b/apps/client/src/app/components/rule/rule.component.html
index aed14da63..7cea512e3 100644
--- a/apps/client/src/app/components/rule/rule.component.html
+++ b/apps/client/src/app/components/rule/rule.component.html
@@ -62,11 +62,7 @@
             <ion-icon name="ellipsis-horizontal" />
           </button>
           <mat-menu #rulesMenu="matMenu" xPosition="before">
-            @if (
-              rule?.isActive &&
-              (rule?.configuration?.thresholdMax ||
-                rule?.configuration?.thresholdMin)
-            ) {
+            @if (rule?.isActive && rule?.configuration) {
               <button mat-menu-item (click)="onCustomizeRule(rule)">
                 <ng-container i18n>Customize</ng-container>...
               </button>