Browse Source

fix(client): dateOfFirstActivity type safety

pull/7050/head
KenTandrian 3 months ago
parent
commit
9fbdf68952
  1. 6
      apps/client/src/app/components/holding-detail-dialog/holding-detail-dialog.component.ts
  2. 8
      libs/ui/src/lib/services/data.service.ts

6
apps/client/src/app/components/holding-detail-dialog/holding-detail-dialog.component.ts

@ -297,7 +297,11 @@ export class GfHoldingDetailDialogComponent implements OnInit {
this.benchmarkDataItems = []; this.benchmarkDataItems = [];
this.countries = {}; this.countries = {};
this.dataProviderInfo = dataProviderInfo; this.dataProviderInfo = dataProviderInfo;
this.dateOfFirstActivity = dateOfFirstActivity;
if (dateOfFirstActivity) {
this.dateOfFirstActivity = dateOfFirstActivity;
}
this.dividendInBaseCurrency = dividendInBaseCurrency; this.dividendInBaseCurrency = dividendInBaseCurrency;
if ( if (

8
libs/ui/src/lib/services/data.service.ts

@ -447,7 +447,7 @@ export class DataService {
symbol: string; symbol: string;
}): Observable< }): Observable<
Omit<PortfolioHoldingResponse, 'dateOfFirstActivity'> & { Omit<PortfolioHoldingResponse, 'dateOfFirstActivity'> & {
dateOfFirstActivity: Date; dateOfFirstActivity: Date | undefined;
} }
> { > {
return this.http return this.http
@ -456,9 +456,13 @@ export class DataService {
) )
.pipe( .pipe(
map((response) => { map((response) => {
const dateOfFirstActivity = response.dateOfFirstActivity
? parseISO(response.dateOfFirstActivity)
: undefined;
return { return {
...response, ...response,
dateOfFirstActivity: parseISO(response.dateOfFirstActivity) dateOfFirstActivity
}; };
}) })
); );

Loading…
Cancel
Save