From a0b222288d35840cc3edba3688983f789ee87c57 Mon Sep 17 00:00:00 2001 From: Trevin Chow Date: Sat, 4 Apr 2026 05:01:22 -0700 Subject: [PATCH] Use i18n translation for regional market cluster risk category name Replace the hardcoded 'Regional Market Cluster Risk' string in getCategoryName() with a call to this.i18nService.getTranslation() using the existing 'rule.regionalMarketClusterRisk.category' key. This brings these five rules in line with how all other rule categories (currency cluster risk, account cluster risk, asset class cluster risk, etc.) already resolve their category names through the i18n service. --- .../rules/regional-market-cluster-risk/asia-pacific.ts | 5 ++++- .../rules/regional-market-cluster-risk/emerging-markets.ts | 5 ++++- .../src/models/rules/regional-market-cluster-risk/europe.ts | 5 ++++- .../src/models/rules/regional-market-cluster-risk/japan.ts | 5 ++++- .../rules/regional-market-cluster-risk/north-america.ts | 5 ++++- 5 files changed, 20 insertions(+), 5 deletions(-) diff --git a/apps/api/src/models/rules/regional-market-cluster-risk/asia-pacific.ts b/apps/api/src/models/rules/regional-market-cluster-risk/asia-pacific.ts index 1242df759..265d422a7 100644 --- a/apps/api/src/models/rules/regional-market-cluster-risk/asia-pacific.ts +++ b/apps/api/src/models/rules/regional-market-cluster-risk/asia-pacific.ts @@ -71,7 +71,10 @@ export class RegionalMarketClusterRiskAsiaPacific extends Rule { } public getCategoryName() { - return 'Regional Market Cluster Risk'; // TODO: Replace hardcoded text with i18n translation + return this.i18nService.getTranslation({ + id: 'rule.regionalMarketClusterRisk.category', + languageCode: this.getLanguageCode() + }); } public getConfiguration() { diff --git a/apps/api/src/models/rules/regional-market-cluster-risk/emerging-markets.ts b/apps/api/src/models/rules/regional-market-cluster-risk/emerging-markets.ts index 8486d843b..4532f4600 100644 --- a/apps/api/src/models/rules/regional-market-cluster-risk/emerging-markets.ts +++ b/apps/api/src/models/rules/regional-market-cluster-risk/emerging-markets.ts @@ -73,7 +73,10 @@ export class RegionalMarketClusterRiskEmergingMarkets extends Rule { } public getCategoryName() { - return 'Regional Market Cluster Risk'; // TODO: Replace hardcoded text with i18n translation + return this.i18nService.getTranslation({ + id: 'rule.regionalMarketClusterRisk.category', + languageCode: this.getLanguageCode() + }); } public getConfiguration() { diff --git a/apps/api/src/models/rules/regional-market-cluster-risk/europe.ts b/apps/api/src/models/rules/regional-market-cluster-risk/europe.ts index 459848db4..a3883c63b 100644 --- a/apps/api/src/models/rules/regional-market-cluster-risk/europe.ts +++ b/apps/api/src/models/rules/regional-market-cluster-risk/europe.ts @@ -71,7 +71,10 @@ export class RegionalMarketClusterRiskEurope extends Rule { } public getCategoryName() { - return 'Regional Market Cluster Risk'; // TODO: Replace hardcoded text with i18n translation + return this.i18nService.getTranslation({ + id: 'rule.regionalMarketClusterRisk.category', + languageCode: this.getLanguageCode() + }); } public getConfiguration() { diff --git a/apps/api/src/models/rules/regional-market-cluster-risk/japan.ts b/apps/api/src/models/rules/regional-market-cluster-risk/japan.ts index d9c1cff6b..12814a87c 100644 --- a/apps/api/src/models/rules/regional-market-cluster-risk/japan.ts +++ b/apps/api/src/models/rules/regional-market-cluster-risk/japan.ts @@ -71,7 +71,10 @@ export class RegionalMarketClusterRiskJapan extends Rule { } public getCategoryName() { - return 'Regional Market Cluster Risk'; // TODO: Replace hardcoded text with i18n translation + return this.i18nService.getTranslation({ + id: 'rule.regionalMarketClusterRisk.category', + languageCode: this.getLanguageCode() + }); } public getConfiguration() { diff --git a/apps/api/src/models/rules/regional-market-cluster-risk/north-america.ts b/apps/api/src/models/rules/regional-market-cluster-risk/north-america.ts index 6180a2cc5..abcf1ac23 100644 --- a/apps/api/src/models/rules/regional-market-cluster-risk/north-america.ts +++ b/apps/api/src/models/rules/regional-market-cluster-risk/north-america.ts @@ -71,7 +71,10 @@ export class RegionalMarketClusterRiskNorthAmerica extends Rule { } public getCategoryName() { - return 'Regional Market Cluster Risk'; // TODO: Replace hardcoded text with i18n translation + return this.i18nService.getTranslation({ + id: 'rule.regionalMarketClusterRisk.category', + languageCode: this.getLanguageCode() + }); } public getConfiguration() {