Improve watchlist for impersonation mode

apps/api/src/app/endpoints/watchlist/watchlist.controller.ts

@@ -2,6 +2,8 @@ import { HasPermission } from '@ghostfolio/api/decorators/has-permission.decorat
 import { HasPermissionGuard } from '@ghostfolio/api/guards/has-permission.guard';
 import { TransformDataSourceInRequestInterceptor } from '@ghostfolio/api/interceptors/transform-data-source-in-request/transform-data-source-in-request.interceptor';
 import { TransformDataSourceInResponseInterceptor } from '@ghostfolio/api/interceptors/transform-data-source-in-response/transform-data-source-in-response.interceptor';
+import { ImpersonationService } from '@ghostfolio/api/services/impersonation/impersonation.service';
+import { HEADER_KEY_IMPERSONATION } from '@ghostfolio/common/config';
 import { WatchlistResponse } from '@ghostfolio/common/interfaces';
 import { permissions } from '@ghostfolio/common/permissions';
 import { RequestWithUser } from '@ghostfolio/common/types';
@@ -11,6 +13,7 @@ import {
   Controller,
   Delete,
   Get,
+  Headers,
   HttpException,
   Inject,
   Param,
@@ -29,6 +32,7 @@ import { WatchlistService } from './watchlist.service';
 @Controller('watchlist')
 export class WatchlistController {
   public constructor(
+    private readonly impersonationService: ImpersonationService,
     @Inject(REQUEST) private readonly request: RequestWithUser,
     private readonly watchlistService: WatchlistService
   ) {}
@@ -79,9 +83,14 @@ export class WatchlistController {
   @HasPermission(permissions.readWatchlist)
   @UseGuards(AuthGuard('jwt'), HasPermissionGuard)
   @UseInterceptors(TransformDataSourceInResponseInterceptor)
-  public async getWatchlistItems(): Promise<WatchlistResponse> {
+  public async getWatchlistItems(
+    @Headers(HEADER_KEY_IMPERSONATION.toLowerCase()) impersonationId: string
+  ): Promise<WatchlistResponse> {
+    const impersonationUserId =
+      await this.impersonationService.validateImpersonationId(impersonationId);
+
     const watchlist = await this.watchlistService.getWatchlistItems(
-      this.request.user.id
+      impersonationUserId || this.request.user.id
     );
 
     return {

apps/api/src/app/endpoints/watchlist/watchlist.module.ts

@@ -1,6 +1,7 @@
 import { TransformDataSourceInRequestModule } from '@ghostfolio/api/interceptors/transform-data-source-in-request/transform-data-source-in-request.module';
 import { TransformDataSourceInResponseModule } from '@ghostfolio/api/interceptors/transform-data-source-in-response/transform-data-source-in-response.module';
 import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
+import { ImpersonationModule } from '@ghostfolio/api/services/impersonation/impersonation.module';
 import { PrismaModule } from '@ghostfolio/api/services/prisma/prisma.module';
 import { DataGatheringModule } from '@ghostfolio/api/services/queues/data-gathering/data-gathering.module';
 import { SymbolProfileModule } from '@ghostfolio/api/services/symbol-profile/symbol-profile.module';
@@ -15,6 +16,7 @@ import { WatchlistService } from './watchlist.service';
   imports: [
     DataGatheringModule,
     DataProviderModule,
+    ImpersonationModule,
     PrismaModule,
     SymbolProfileModule,
     TransformDataSourceInRequestModule,

apps/client/src/app/components/home-watchlist/home-watchlist.component.ts

@@ -1,4 +1,5 @@
 import { DataService } from '@ghostfolio/client/services/data.service';
+import { ImpersonationStorageService } from '@ghostfolio/client/services/impersonation-storage.service';
 import { UserService } from '@ghostfolio/client/services/user/user.service';
 import {
   AssetProfileIdentifier,
@@ -44,6 +45,7 @@ import { CreateWatchlistItemDialogParams } from './create-watchlist-item-dialog/
 })
 export class HomeWatchlistComponent implements OnDestroy, OnInit {
   public deviceType: string;
+  public hasImpersonationId: boolean;
   public hasPermissionToCreateWatchlistItem: boolean;
   public hasPermissionToDeleteWatchlistItem: boolean;
   public user: User;
@@ -56,12 +58,20 @@ export class HomeWatchlistComponent implements OnDestroy, OnInit {
     private dataService: DataService,
     private deviceService: DeviceDetectorService,
     private dialog: MatDialog,
+    private impersonationStorageService: ImpersonationStorageService,
     private route: ActivatedRoute,
     private router: Router,
     private userService: UserService
   ) {
     this.deviceType = this.deviceService.getDeviceInfo().deviceType;
 
+    this.impersonationStorageService
+      .onChangeHasImpersonation()
+      .pipe(takeUntil(this.unsubscribeSubject))
+      .subscribe((impersonationId) => {
+        this.hasImpersonationId = !!impersonationId;
+      });
+
     this.route.queryParams
       .pipe(takeUntil(this.unsubscribeSubject))
       .subscribe((params) => {
@@ -76,14 +86,18 @@ export class HomeWatchlistComponent implements OnDestroy, OnInit {
         if (state?.user) {
           this.user = state.user;
 
-          this.hasPermissionToCreateWatchlistItem = hasPermission(
-            this.user.permissions,
-            permissions.createWatchlistItem
-          );
-          this.hasPermissionToDeleteWatchlistItem = hasPermission(
-            this.user.permissions,
-            permissions.deleteWatchlistItem
-          );
+          this.hasPermissionToCreateWatchlistItem =
+            !this.hasImpersonationId &&
+            hasPermission(
+              this.user.permissions,
+              permissions.createWatchlistItem
+            );
+          this.hasPermissionToDeleteWatchlistItem =
+            !this.hasImpersonationId &&
+            hasPermission(
+              this.user.permissions,
+              permissions.deleteWatchlistItem
+            );
 
           this.changeDetectorRef.markForCheck();
         }

apps/client/src/app/components/home-watchlist/home-watchlist.html

@@ -20,7 +20,7 @@
     </div>
   </div>
 </div>
-@if (hasPermissionToCreateWatchlistItem) {
+@if (!hasImpersonationId && hasPermissionToCreateWatchlistItem) {
   <div class="fab-container">
     <a
       class="align-items-center d-flex justify-content-center"