Browse Source
Bugfix/fix missing localization for alias fallback on public page (#4610)
* Fix missing localization
* Update changelog
pull/4613/head
Thomas Kaul
3 days ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with
3 additions and
1 deletions
-
CHANGELOG.md
-
apps/client/src/app/pages/public/public-page.component.ts
-
apps/client/src/app/pages/public/public-page.html
|
|
@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
### Fixed |
|
|
### Fixed |
|
|
|
|
|
|
|
|
- Improved the file selector of the activities import functionality to accept case-insensitive file extensions (`.CSV` and `.JSON`) |
|
|
- Improved the file selector of the activities import functionality to accept case-insensitive file extensions (`.CSV` and `.JSON`) |
|
|
|
|
|
- Fixed the missing localization for "someone" on the public page |
|
|
|
|
|
|
|
|
## 2.155.0 - 2025-04-23 |
|
|
## 2.155.0 - 2025-04-23 |
|
|
|
|
|
|
|
|
|
|
|
@ -30,6 +30,7 @@ export class PublicPageComponent implements OnInit { |
|
|
public countries: { |
|
|
public countries: { |
|
|
[code: string]: { name: string; value: number }; |
|
|
[code: string]: { name: string; value: number }; |
|
|
}; |
|
|
}; |
|
|
|
|
|
public defaultAlias = $localize`someone`; |
|
|
public deviceType: string; |
|
|
public deviceType: string; |
|
|
public holdings: PublicPortfolioResponse['holdings'][string][]; |
|
|
public holdings: PublicPortfolioResponse['holdings'][string][]; |
|
|
public markets: { |
|
|
public markets: { |
|
|
|
|
|
@ -2,7 +2,7 @@ |
|
|
<div class="row"> |
|
|
<div class="row"> |
|
|
<div class="col"> |
|
|
<div class="col"> |
|
|
<h1 class="h4 mb-3 text-center" i18n> |
|
|
<h1 class="h4 mb-3 text-center" i18n> |
|
|
Hello, {{ publicPortfolioDetails?.alias ?? 'someone' }} has shared a |
|
|
Hello, {{ publicPortfolioDetails?.alias ?? defaultAlias }} has shared a |
|
|
<strong>Portfolio</strong> with you! |
|
|
<strong>Portfolio</strong> with you! |
|
|
</h1> |
|
|
</h1> |
|
|
</div> |
|
|
</div> |
|
|
|
