Browse Source

Bugfix/fix missing localization for alias fallback on public page (#4610)

* Fix missing localization

* Update changelog
pull/4613/head
Thomas Kaul 3 days ago
committed by GitHub
parent
commit
a5e13d30ae
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 1
      CHANGELOG.md
  2. 1
      apps/client/src/app/pages/public/public-page.component.ts
  3. 2
      apps/client/src/app/pages/public/public-page.html

1
CHANGELOG.md

@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Improved the file selector of the activities import functionality to accept case-insensitive file extensions (`.CSV` and `.JSON`)
- Fixed the missing localization for "someone" on the public page
## 2.155.0 - 2025-04-23

1
apps/client/src/app/pages/public/public-page.component.ts

@ -30,6 +30,7 @@ export class PublicPageComponent implements OnInit {
public countries: {
[code: string]: { name: string; value: number };
};
public defaultAlias = $localize`someone`;
public deviceType: string;
public holdings: PublicPortfolioResponse['holdings'][string][];
public markets: {

2
apps/client/src/app/pages/public/public-page.html

@ -2,7 +2,7 @@
<div class="row">
<div class="col">
<h1 class="h4 mb-3 text-center" i18n>
Hello, {{ publicPortfolioDetails?.alias ?? 'someone' }} has shared a
Hello, {{ publicPortfolioDetails?.alias ?? defaultAlias }} has shared a
<strong>Portfolio</strong> with you!
</h1>
</div>

Loading…
Cancel
Save