NPM update, fixes & fix lint

apps/api/src/app/portfolio/calculator/portfolio-calculator.ts

@@ -766,12 +766,6 @@ export abstract class PortfolioCalculator {
     return { chart };
   }
 
-  public async getSnapshot() {
-    await this.snapshotPromise;
-
-    return this.snapshot;
-  }
-
   public getStartDate() {
     let firstAccountBalanceDate: Date;
     let firstActivityDate: Date;
@@ -797,24 +791,6 @@ export abstract class PortfolioCalculator {
     return min([firstAccountBalanceDate, firstActivityDate]);
   }
 
-  protected abstract getSymbolMetrics({
-    chartDateMap,
-    dataSource,
-    end,
-    exchangeRates,
-    marketSymbolMap,
-    start,
-    symbol
-  }: {
-    chartDateMap: { [date: string]: boolean };
-    end: Date;
-    exchangeRates: { [dateString: string]: number };
-    marketSymbolMap: {
-      [date: string]: { [symbol: string]: Big };
-    };
-    start: Date;
-  } & AssetProfileIdentifier): SymbolMetrics;
-
   public getTransactionPoints() {
     return this.transactionPoints;
   }
@@ -1053,37 +1029,6 @@ export abstract class PortfolioCalculator {
     }
   }
 
-  public getStartDate() {
-    let firstAccountBalanceDate: Date;
-    let firstActivityDate: Date;
-
-    try {
-      const firstAccountBalanceDateString = first(
-        this.accountBalanceItems
-      )?.date;
-      firstAccountBalanceDate = firstAccountBalanceDateString
-        ? parseDate(firstAccountBalanceDateString)
-        : new Date();
-    } catch (error) {
-      firstAccountBalanceDate = new Date();
-    }
-
-    try {
-      const firstActivityDateString = this.transactionPoints[0].date;
-      firstActivityDate = firstActivityDateString
-        ? parseDate(firstActivityDateString)
-        : new Date();
-    } catch (error) {
-      firstActivityDate = new Date();
-    }
-
-    return min([firstAccountBalanceDate, firstActivityDate]);
-  }
-
-  public getTransactionPoints() {
-    return this.transactionPoints;
-  }
-
   private getChartDateMap({
     endDate,
     startDate,

apps/api/src/app/portfolio/portfolio.controller.ts

@@ -161,24 +161,22 @@ export class PortfolioController {
           portfolioPosition.investment / totalInvestment;
         portfolioPosition.valueInPercentage =
           portfolioPosition.valueInBaseCurrency / totalValue;
-        (portfolioPosition.assetClass = hasDetails
+        portfolioPosition.assetClass = hasDetails
           ? portfolioPosition.assetClass
-          : undefined),
-          (portfolioPosition.assetSubClass = hasDetails
-            ? portfolioPosition.assetSubClass
-            : undefined),
-          (portfolioPosition.countries = hasDetails
-            ? portfolioPosition.countries
-            : []),
-          (portfolioPosition.currency = hasDetails
-            ? portfolioPosition.currency
-            : undefined),
-          (portfolioPosition.markets = hasDetails
-            ? portfolioPosition.markets
-            : undefined),
-          (portfolioPosition.sectors = hasDetails
-            ? portfolioPosition.sectors
-            : []);
+          : undefined;
+        portfolioPosition.assetSubClass = hasDetails
+          ? portfolioPosition.assetSubClass
+          : undefined;
+        portfolioPosition.countries = hasDetails
+          ? portfolioPosition.countries
+          : [];
+        portfolioPosition.currency = hasDetails
+          ? portfolioPosition.currency
+          : undefined;
+        portfolioPosition.markets = hasDetails
+          ? portfolioPosition.markets
+          : undefined;
+        portfolioPosition.sectors = hasDetails ? portfolioPosition.sectors : [];
       }
 
       for (const [name, { valueInBaseCurrency }] of Object.entries(accounts)) {

apps/api/src/app/portfolio/portfolio.service.ts

@@ -1714,24 +1714,6 @@ export class PortfolioService {
     return { markets, marketsAdvanced };
   }
 
-  private getReportStatistics(
-    evaluatedRules: PortfolioReportResponse['rules']
-  ): PortfolioReportResponse['statistics'] {
-    const rulesActiveCount = Object.values(evaluatedRules)
-      .flat()
-      .filter((rule) => {
-        return rule?.isActive === true;
-      }).length;
-
-    const rulesFulfilledCount = Object.values(evaluatedRules)
-      .flat()
-      .filter((rule) => {
-        return rule?.value === true;
-      }).length;
-
-    return { rulesActiveCount, rulesFulfilledCount };
-  }
-
   @LogPerformance
   private getReportStatistics(
     evaluatedRules: PortfolioReportResponse['rules']

apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts

@@ -219,8 +219,8 @@ export class CreateOrUpdateActivityDialog implements OnDestroy {
             (this.activityForm.get('fee').value ?? 0);
         } else if (this.activityForm.get('type').value === 'STAKE') {
           this.total =
-            this.activityForm.get('quantity').value * this.currentMarketPrice ??
-            0;
+            this.activityForm.get('quantity').value *
+            (this.currentMarketPrice ?? 0);
         } else {
           this.total =
             this.activityForm.get('quantity').value *

package.json

@@ -156,17 +156,17 @@
     "@eslint/js": "9.18.0",
     "@nestjs/schematics": "10.2.3",
     "@nestjs/testing": "10.4.15",
-    "@nx/angular": "20.3.2",
-    "@nx/cypress": "20.3.2",
-    "@nx/eslint-plugin": "20.3.2",
-    "@nx/jest": "20.3.2",
-    "@nx/js": "20.3.2",
-    "@nx/module-federation": "20.3.2",
-    "@nx/nest": "20.3.2",
-    "@nx/node": "20.3.2",
-    "@nx/storybook": "20.3.2",
-    "@nx/web": "20.3.2",
-    "@nx/workspace": "20.3.2",
+    "@nx/angular": "20.3.3",
+    "@nx/cypress": "20.3.3",
+    "@nx/eslint-plugin": "20.3.3",
+    "@nx/jest": "20.3.3",
+    "@nx/js": "20.3.3",
+    "@nx/module-federation": "20.3.3",
+    "@nx/nest": "20.3.3",
+    "@nx/node": "20.3.3",
+    "@nx/storybook": "20.3.3",
+    "@nx/web": "20.3.3",
+    "@nx/workspace": "20.3.3",
     "@schematics/angular": "19.0.6",
     "@simplewebauthn/types": "9.0.1",
     "@storybook/addon-essentials": "8.4.7",
@@ -196,7 +196,7 @@
     "jest": "29.7.0",
     "jest-environment-jsdom": "29.7.0",
     "jest-preset-angular": "14.4.2",
-    "nx": "20.3.2",
+    "nx": "20.3.3",
     "prettier": "3.4.2",
     "prettier-plugin-organize-attributes": "1.0.0",
     "prisma": "6.2.1",