From a7bfc4ae46836827aa7bae3abfcf37c5a38a1e78 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Wed, 12 Feb 2025 17:41:32 +0100 Subject: [PATCH] Minor improvements --- .../rules/regional-market-cluster-risk/asia-pacific.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/apps/api/src/models/rules/regional-market-cluster-risk/asia-pacific.ts b/apps/api/src/models/rules/regional-market-cluster-risk/asia-pacific.ts index 53228bfda..283f43676 100644 --- a/apps/api/src/models/rules/regional-market-cluster-risk/asia-pacific.ts +++ b/apps/api/src/models/rules/regional-market-cluster-risk/asia-pacific.ts @@ -15,11 +15,11 @@ export class RegionalMarketClusterRiskAsiaPacific extends Rule { ) { super(exchangeRateDataService, { key: RegionalMarketClusterRiskAsiaPacific.name, - name: 'Asia Pacific' + name: 'Asia-Pacific' }); - this.currentValueInBaseCurrency = currentValueInBaseCurrency; this.asiaPacificValueInBaseCurrency = asiaPacificValueInBaseCurrency; + this.currentValueInBaseCurrency = currentValueInBaseCurrency; } public evaluate(ruleSettings: Settings) { @@ -29,14 +29,14 @@ export class RegionalMarketClusterRiskAsiaPacific extends Rule { if (asiaPacificMarketValueRatio > ruleSettings.thresholdMax) { return { - evaluation: `The Asia Pacific market contribution of your current investment (${(asiaPacificMarketValueRatio * 100).toPrecision(3)}%) exceeds ${( + evaluation: `The Asia-Pacific market contribution of your current investment (${(asiaPacificMarketValueRatio * 100).toPrecision(3)}%) exceeds ${( ruleSettings.thresholdMax * 100 ).toPrecision(3)}%`, value: false }; } else if (asiaPacificMarketValueRatio < ruleSettings.thresholdMin) { return { - evaluation: `The Asia Pacific market contribution of your current investment (${(asiaPacificMarketValueRatio * 100).toPrecision(3)}%) is below ${( + evaluation: `The Asia-Pacific market contribution of your current investment (${(asiaPacificMarketValueRatio * 100).toPrecision(3)}%) is below ${( ruleSettings.thresholdMin * 100 ).toPrecision(3)}%`, value: false @@ -44,7 +44,7 @@ export class RegionalMarketClusterRiskAsiaPacific extends Rule { } return { - evaluation: `The Asia Pacific market contribution of your current investment (${(asiaPacificMarketValueRatio * 100).toPrecision(3)}%) is within the range of ${( + evaluation: `The Asia-Pacific market contribution of your current investment (${(asiaPacificMarketValueRatio * 100).toPrecision(3)}%) is within the range of ${( ruleSettings.thresholdMin * 100 ).toPrecision( 3