Browse Source

fix: address additional code review comments

- Change Korean to 'Korean (한국어)' and move before nl in footer
- Remove ko-KR from user account settings component
- Wrap Korean option in experimental features flag
- Move 한국어 to end of language list in product page
- Reorder Korean configurations before nl in project.json
- Reorder Korean translation file before nl in targetFiles
pull/6136/head
yaro 2 weeks ago
parent
commit
a8c33ddb6d
  1. 12
      apps/client/project.json
  2. 6
      apps/client/src/app/components/footer/footer.component.html
  3. 1
      apps/client/src/app/components/user-account-settings/user-account-settings.component.ts
  4. 10
      apps/client/src/app/components/user-account-settings/user-account-settings.html
  5. 4
      apps/client/src/app/pages/resources/personal-finance-tools/product-page.component.ts

12
apps/client/project.json

@ -14,10 +14,6 @@
"baseHref": "/de/",
"translation": "apps/client/src/locales/messages.de.xlf"
},
"ko": {
"baseHref": "/ko/",
"translation": "apps/client/src/locales/messages.ko.xlf"
},
"es": {
"baseHref": "/es/",
"translation": "apps/client/src/locales/messages.es.xlf"
@ -30,6 +26,10 @@
"baseHref": "/it/",
"translation": "apps/client/src/locales/messages.it.xlf"
},
"ko": {
"baseHref": "/ko/",
"translation": "apps/client/src/locales/messages.ko.xlf"
},
"nl": {
"baseHref": "/nl/",
"translation": "apps/client/src/locales/messages.nl.xlf"
@ -278,13 +278,13 @@
"messages.es.xlf",
"messages.fr.xlf",
"messages.it.xlf",
"messages.ko.xlf",
"messages.nl.xlf",
"messages.pl.xlf",
"messages.pt.xlf",
"messages.tr.xlf",
"messages.uk.xlf",
"messages.zh.xlf",
"messages.ko.xlf"
"messages.zh.xlf"
],
"trim": true
}

6
apps/client/src/app/components/footer/footer.component.html

@ -139,6 +139,9 @@
<li>
<a href="../it" title="Ghostfolio in Italiano">Italiano</a>
</li>
<li>
<a href="../ko" title="Ghostfolio in Korean (한국어)">Korean (한국어)</a>
</li>
<li>
<a href="../nl" title="Ghostfolio in Nederlands">Nederlands</a>
</li>
@ -148,9 +151,6 @@
<li>
<a href="../pt" title="Ghostfolio in Português">Português</a>
</li>
<li>
<a href="../ko" title="Ghostfolio in 한국어">한국어</a>
</li>
<li>
<a href="../tr" title="Ghostfolio in Türkçe">Türkçe</a>
</li>

1
apps/client/src/app/components/user-account-settings/user-account-settings.component.ts

@ -90,7 +90,6 @@ export class GfUserAccountSettingsComponent implements OnDestroy, OnInit {
'fr',
'it',
'ko',
'ko-KR',
'nl',
'pl',
'pt',

10
apps/client/src/app/components/user-account-settings/user-account-settings.html

@ -102,10 +102,12 @@
>Italiano (<ng-container i18n>Community</ng-container
>)</mat-option
>
<mat-option value="ko"
>한국어 (<ng-container i18n>Community</ng-container
>)</mat-option
>
@if (user?.settings?.isExperimentalFeatures) {
<mat-option value="ko"
>한국어 (<ng-container i18n>Community</ng-container
>)</mat-option
>
}
<mat-option value="nl"
>Nederlands (<ng-container i18n>Community</ng-container
>)</mat-option

4
apps/client/src/app/pages/resources/personal-finance-tools/product-page.component.ts

@ -44,7 +44,6 @@ export class GfProductPageComponent implements OnInit {
key: 'ghostfolio',
languages: [
'Deutsch',
'한국어',
'English',
'Español',
'Français',
@ -52,7 +51,8 @@ export class GfProductPageComponent implements OnInit {
'Nederlands',
'Português',
'Türkçe',
'简体中文'
'简体中文',
'한국어'
],
name: 'Ghostfolio',
origin: $localize`Switzerland`,

Loading…
Cancel
Save