From a907381322418714fab51957868f36ed0d2cce5c Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Fri, 7 Aug 2026 21:13:57 +0200
Subject: [PATCH] Add emergency fund coverage rule

---
 .../rules/emergency-fund/emergency-fund-coverage.ts      | 9 +--------
 apps/api/src/services/i18n/i18n.service.ts               | 5 ++++-
 apps/client/src/app/pages/i18n/i18n-page.html            | 9 +++------
 3 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/apps/api/src/models/rules/emergency-fund/emergency-fund-coverage.ts b/apps/api/src/models/rules/emergency-fund/emergency-fund-coverage.ts
index 8505ef991..479781acc 100644
--- a/apps/api/src/models/rules/emergency-fund/emergency-fund-coverage.ts
+++ b/apps/api/src/models/rules/emergency-fund/emergency-fund-coverage.ts
@@ -43,11 +43,7 @@ export class EmergencyFundCoverage extends Rule<Settings> {
             baseCurrency: ruleSettings.baseCurrency,
             emergencyFund: this.emergencyFundInBaseCurrency.toLocaleString(
               ruleSettings.locale
-            ),
-            emergencyFundHoldingsValue:
-              this.emergencyFundHoldingsValueInBaseCurrency.toLocaleString(
-                ruleSettings.locale
-              )
+            )
           }
         }),
         value: false
@@ -65,9 +61,6 @@ export class EmergencyFundCoverage extends Rule<Settings> {
           languageCode: this.getLanguageCode(),
           placeholders: {
             baseCurrency: ruleSettings.baseCurrency,
-            coverage: coverageInBaseCurrency.toLocaleString(
-              ruleSettings.locale
-            ),
             emergencyFund: this.emergencyFundInBaseCurrency.toLocaleString(
               ruleSettings.locale
             )
diff --git a/apps/api/src/services/i18n/i18n.service.ts b/apps/api/src/services/i18n/i18n.service.ts
index 65c51b2f0..83eb3a3ac 100644
--- a/apps/api/src/services/i18n/i18n.service.ts
+++ b/apps/api/src/services/i18n/i18n.service.ts
@@ -45,7 +45,10 @@ export class I18nService implements OnModuleInit {
 
     if (placeholders) {
       for (const [key, value] of Object.entries(placeholders)) {
-        translatedText = translatedText.replace(`\${${key}}`, String(value));
+        translatedText = translatedText.replace(
+          new RegExp(`\\$\\{${key}\\}`, 'g'),
+          String(value)
+        );
       }
     }
 
diff --git a/apps/client/src/app/pages/i18n/i18n-page.html b/apps/client/src/app/pages/i18n/i18n-page.html
index 15c58fbf2..8636a6976 100644
--- a/apps/client/src/app/pages/i18n/i18n-page.html
+++ b/apps/client/src/app/pages/i18n/i18n-page.html
@@ -144,15 +144,12 @@
       <li i18n="@@rule.emergencyFund.category">Emergency Fund</li>
       <li i18n="@@rule.emergencyFundCoverage">Coverage</li>
       <li i18n="@@rule.emergencyFundCoverage.false.over">
-        The assets tagged as emergency fund
-        ($&#123;emergencyFundHoldingsValue&#125; $&#123;baseCurrency&#125;)
-        exceed your emergency fund of $&#123;emergencyFund&#125;
-        $&#123;baseCurrency&#125;
+        The assets tagged as emergency fund exceed your emergency fund of
+        $&#123;emergencyFund&#125; $&#123;baseCurrency&#125;
       </li>
       <li i18n="@@rule.emergencyFundCoverage.false.under">
         Your emergency fund of $&#123;emergencyFund&#125;
-        $&#123;baseCurrency&#125; is not covered ($&#123;coverage&#125;
-        $&#123;baseCurrency&#125; available)
+        $&#123;baseCurrency&#125; is not covered
       </li>
       <li i18n="@@rule.emergencyFundCoverage.true">
         Your emergency fund of $&#123;emergencyFund&#125;