From ad3ebd42bb44488856a50e74821a1bfb4db53efb Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sun, 5 Feb 2023 09:49:37 +0100 Subject: [PATCH 1/2] Feature/migrate mat suffix to angular material 15 (#1655) * Migrate matSuffix to @angular/material 15 * Update changelog --- CHANGELOG.md | 8 ++++ .../market-data-detail-dialog.html | 24 +++++------ .../market-data-detail-dialog.module.ts | 6 +-- .../market-data-detail-dialog.scss | 16 ++----- .../portfolio/activities/activities-page.html | 2 +- .../activities/activities-page.module.ts | 4 +- ...ate-or-update-activity-dialog.component.ts | 2 +- .../create-or-update-activity-dialog.html | 42 +++++++++---------- ...create-or-update-activity-dialog.module.ts | 14 +++---- .../create-or-update-activity-dialog.scss | 35 ++++------------ 10 files changed, 65 insertions(+), 88 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2b55ba893..2cd26e71e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## Unreleased + +### Changed + +- Migrated the style of `ActivitiesPageModule` to `@angular/material` `15` (mdc) +- Migrated the style of `GfCreateOrUpdateActivityDialogModule` to `@angular/material` `15` (mdc) +- Migrated the style of `GfMarketDataDetailDialogModule` to `@angular/material` `15` (mdc) + ## 1.231.0 - 2023-02-04 ### Added diff --git a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.html b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.html index 230133de7..1797833c4 100644 --- a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.html +++ b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.html @@ -1,6 +1,6 @@

Details for {{ data.symbol }}

-
+
Date @@ -11,7 +11,7 @@ [matDatepicker]="date" [(ngModel)]="data.date" /> - +
-
+
Market Price - {{ data.currency }} - + {{ data.currency }} +
diff --git a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.module.ts b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.module.ts index 14aa2199e..b46158505 100644 --- a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.module.ts +++ b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.module.ts @@ -2,10 +2,10 @@ import { CommonModule } from '@angular/common'; import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core'; import { FormsModule, ReactiveFormsModule } from '@angular/forms'; import { MatDatepickerModule } from '@angular/material/datepicker'; -import { MatLegacyButtonModule as MatButtonModule } from '@angular/material/legacy-button'; +import { MatButtonModule } from '@angular/material/button'; import { MatLegacyDialogModule as MatDialogModule } from '@angular/material/legacy-dialog'; -import { MatLegacyFormFieldModule as MatFormFieldModule } from '@angular/material/legacy-form-field'; -import { MatLegacyInputModule as MatInputModule } from '@angular/material/legacy-input'; +import { MatFormFieldModule } from '@angular/material/form-field'; +import { MatInputModule } from '@angular/material/input'; import { MarketDataDetailDialog } from './market-data-detail-dialog.component'; diff --git a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.scss b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.scss index 91922978c..c94c65c54 100644 --- a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.scss +++ b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.scss @@ -4,19 +4,9 @@ .mat-dialog-content { max-height: unset; - .mat-form-field-appearance-outline { - ::ng-deep { - .mat-form-field-suffix { - top: -0.3rem; - } - - .mat-form-field-wrapper { - padding-bottom: 0; - } - } - - ion-icon { - font-size: 130%; + .mat-mdc-button { + &.apply-current-market-price { + height: 56px; } } } diff --git a/apps/client/src/app/pages/portfolio/activities/activities-page.html b/apps/client/src/app/pages/portfolio/activities/activities-page.html index cec456c53..d958598c1 100644 --- a/apps/client/src/app/pages/portfolio/activities/activities-page.html +++ b/apps/client/src/app/pages/portfolio/activities/activities-page.html @@ -33,7 +33,7 @@ [queryParams]="{ createDialog: true }" [routerLink]="[]" > - +
diff --git a/apps/client/src/app/pages/portfolio/activities/activities-page.module.ts b/apps/client/src/app/pages/portfolio/activities/activities-page.module.ts index 1f69f60f3..28d4437a9 100644 --- a/apps/client/src/app/pages/portfolio/activities/activities-page.module.ts +++ b/apps/client/src/app/pages/portfolio/activities/activities-page.module.ts @@ -1,7 +1,7 @@ import { CommonModule } from '@angular/common'; import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core'; -import { MatLegacyButtonModule as MatButtonModule } from '@angular/material/legacy-button'; -import { MatLegacySnackBarModule as MatSnackBarModule } from '@angular/material/legacy-snack-bar'; +import { MatButtonModule } from '@angular/material/button'; +import { MatSnackBarModule } from '@angular/material/snack-bar'; import { RouterModule } from '@angular/router'; import { ImportActivitiesService } from '@ghostfolio/client/services/import-activities.service'; import { GfActivitiesTableModule } from '@ghostfolio/ui/activities-table/activities-table.module'; diff --git a/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts b/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts index cbe740adc..0fa6ae580 100644 --- a/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts +++ b/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts @@ -10,7 +10,7 @@ import { } from '@angular/core'; import { FormBuilder, FormGroup, Validators } from '@angular/forms'; import { DateAdapter, MAT_DATE_LOCALE } from '@angular/material/core'; -import { MatLegacyAutocompleteSelectedEvent as MatAutocompleteSelectedEvent } from '@angular/material/legacy-autocomplete'; +import { MatAutocompleteSelectedEvent } from '@angular/material/autocomplete'; import { MAT_LEGACY_DIALOG_DATA as MAT_DIALOG_DATA, MatLegacyDialogRef as MatDialogRef diff --git a/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.html b/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.html index e5b215fbc..1b46ecf69 100644 --- a/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.html +++ b/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.html @@ -6,7 +6,7 @@ >

Update activity

Add activity

-
+
Type @@ -76,7 +76,7 @@
Currency - + {{ currency }} @@ -93,7 +93,7 @@ Date - +
-
+
@@ -121,20 +121,20 @@ - {{ activityForm.controls['currency'].value }} - +
@@ -142,7 +142,7 @@
@@ -157,7 +157,7 @@ Fee - {{ activityForm.controls['currency'].value }} @@ -207,8 +207,8 @@
Tags - - + {{ tag.name }} - + - + Date: Sun, 5 Feb 2023 11:44:06 +0100 Subject: [PATCH 2/2] Feature/upgrade ng extract i18n merge to version 2.5.0 (#1656) * Upgrade ng-extract-i18n-merge to version 2.5.0 * Update changelog --- CHANGELOG.md | 1 + package.json | 2 +- yarn.lock | 82 ++++++++++++++++++++++++++-------------------------- 3 files changed, 43 insertions(+), 42 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2cd26e71e..391e711a3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Migrated the style of `ActivitiesPageModule` to `@angular/material` `15` (mdc) - Migrated the style of `GfCreateOrUpdateActivityDialogModule` to `@angular/material` `15` (mdc) - Migrated the style of `GfMarketDataDetailDialogModule` to `@angular/material` `15` (mdc) +- Upgraded `ng-extract-i18n-merge` from version `2.1.2` to `2.5.0` ## 1.231.0 - 2023-02-04 diff --git a/package.json b/package.json index cc143c30b..8379c6c1f 100644 --- a/package.json +++ b/package.json @@ -109,7 +109,7 @@ "ionicons": "6.0.4", "lodash": "4.17.21", "ms": "3.0.0-canary.1", - "ng-extract-i18n-merge": "2.1.2", + "ng-extract-i18n-merge": "2.5.0", "ngx-device-detector": "3.0.0", "ngx-markdown": "14.0.1", "ngx-skeleton-loader": "5.0.0", diff --git a/yarn.lock b/yarn.lock index e6cc1a7f3..c07e369db 100644 --- a/yarn.lock +++ b/yarn.lock @@ -124,17 +124,6 @@ rxjs "6.6.7" source-map "0.7.3" -"@angular-devkit/core@14.1.2", "@angular-devkit/core@^13.0.0 || ^14.0.0": - version "14.1.2" - resolved "https://registry.npmjs.org/@angular-devkit/core/-/core-14.1.2.tgz" - integrity sha512-fIfymD1erjoj1eVh7pa/dvOtUhSd7sEOGuWEJ81HJqdzwZbPWweRu3Nh/9kj/ttUy8xawWfdJHLwyG2KnRu0DA== - dependencies: - ajv "8.11.0" - ajv-formats "2.1.1" - jsonc-parser "3.1.0" - rxjs "6.6.7" - source-map "0.7.4" - "@angular-devkit/core@14.2.1": version "14.2.1" resolved "https://registry.npmjs.org/@angular-devkit/core/-/core-14.2.1.tgz" @@ -157,6 +146,17 @@ rxjs "6.6.7" source-map "0.7.4" +"@angular-devkit/core@15.1.4", "@angular-devkit/core@^13.0.0 || ^14.0.0 || ^15.0.0": + version "15.1.4" + resolved "https://registry.yarnpkg.com/@angular-devkit/core/-/core-15.1.4.tgz#462f123d56f9298cb04b3fa31b425fc31abb76c5" + integrity sha512-PW5MRmd9DHJR4FaXchwQtj9pXnsghSTnwRvfZeCRNYgU2sv0DKyTV+YTSJB+kNXnoPNG1Je6amDEkiXecpspXg== + dependencies: + ajv "8.12.0" + ajv-formats "2.1.1" + jsonc-parser "3.2.0" + rxjs "6.6.7" + source-map "0.7.4" + "@angular-devkit/schematics@14.0.5": version "14.0.5" resolved "https://registry.npmjs.org/@angular-devkit/schematics/-/schematics-14.0.5.tgz" @@ -168,17 +168,6 @@ ora "5.4.1" rxjs "6.6.7" -"@angular-devkit/schematics@14.1.2", "@angular-devkit/schematics@^13.0.0 || ^14.0.0": - version "14.1.2" - resolved "https://registry.npmjs.org/@angular-devkit/schematics/-/schematics-14.1.2.tgz" - integrity sha512-vC9UA3heXbq9CAkwMXHJfIu0G7Ty2oTJ5PtrrFQpig1PrFnRfr4sg+qRS1CLsEAJYQNo14xV55OQkKEPTij/Gg== - dependencies: - "@angular-devkit/core" "14.1.2" - jsonc-parser "3.1.0" - magic-string "0.26.2" - ora "5.4.1" - rxjs "6.6.7" - "@angular-devkit/schematics@14.2.1": version "14.2.1" resolved "https://registry.npmjs.org/@angular-devkit/schematics/-/schematics-14.2.1.tgz" @@ -201,6 +190,17 @@ ora "5.4.1" rxjs "6.6.7" +"@angular-devkit/schematics@15.1.4", "@angular-devkit/schematics@^13.0.0 || ^14.0.0 || ^15.0.0": + version "15.1.4" + resolved "https://registry.yarnpkg.com/@angular-devkit/schematics/-/schematics-15.1.4.tgz#30e38777f1bd98e20e6dbe1bfddabc3bcd42605f" + integrity sha512-jpddxo9Qd2yRQ1t9FLhAx5S+luz6HkyhDytq0LFKbxf9ikf1J4oy9riPBFl4pRmrNARWcHZ6GbD20/Ky8PjmXQ== + dependencies: + "@angular-devkit/core" "15.1.4" + jsonc-parser "3.2.0" + magic-string "0.27.0" + ora "5.4.1" + rxjs "6.6.7" + "@angular-eslint/bundled-angular-compiler@15.2.0": version "15.2.0" resolved "https://registry.yarnpkg.com/@angular-eslint/bundled-angular-compiler/-/bundled-angular-compiler-15.2.0.tgz#506f94c96039346f33ba92222062edbf3943543e" @@ -4864,14 +4864,14 @@ "@angular-devkit/schematics" "15.1.3" jsonc-parser "3.2.0" -"@schematics/angular@^13.0.0 || ^14.0.0": - version "14.1.2" - resolved "https://registry.npmjs.org/@schematics/angular/-/angular-14.1.2.tgz" - integrity sha512-vttvYpffkG/cy9aUCXLW+Dc0msUNbyoFXTQRHN/MYX5uNVvXaRCEzWVE3tp87Dt5XlGo2r9e21gNAoY1TyXj3Q== +"@schematics/angular@^13.0.0 || ^14.0.0 || ^15.0.0": + version "15.1.4" + resolved "https://registry.yarnpkg.com/@schematics/angular/-/angular-15.1.4.tgz#2a5ef92fc5852f6d3acb0ec6f3db81deffd9d0f3" + integrity sha512-4SV8dDGZeSvts01b8y2W6FmpDD0dQhBlGMhMJKC/tUnhfNKfYCs2VKtMBsIc3ZiGP2yoA3+nUiMmtS6hEkXYHw== dependencies: - "@angular-devkit/core" "14.1.2" - "@angular-devkit/schematics" "14.1.2" - jsonc-parser "3.1.0" + "@angular-devkit/core" "15.1.4" + "@angular-devkit/schematics" "15.1.4" + jsonc-parser "3.2.0" "@simplewebauthn/browser@5.2.1": version "5.2.1" @@ -16273,16 +16273,16 @@ nested-error-stacks@^2.0.0, nested-error-stacks@^2.1.0: resolved "https://registry.npmjs.org/nested-error-stacks/-/nested-error-stacks-2.1.1.tgz" integrity sha512-9iN1ka/9zmX1ZvLV9ewJYEk9h7RyRRtqdK0woXcqohu8EWIerfPUjYJPg0ULy0UqP7cslmdGc8xKDJcojlKiaw== -ng-extract-i18n-merge@2.1.2: - version "2.1.2" - resolved "https://registry.npmjs.org/ng-extract-i18n-merge/-/ng-extract-i18n-merge-2.1.2.tgz" - integrity sha512-dRo/oO4m3tr26uE4+DHJh0iTqSV3qVl+WGTSHGKKyAM628dP3hZunhBTs7fCpLs57aEex84cJax8X+Y8wmBXTQ== +ng-extract-i18n-merge@2.5.0: + version "2.5.0" + resolved "https://registry.yarnpkg.com/ng-extract-i18n-merge/-/ng-extract-i18n-merge-2.5.0.tgz#bc58fd8f50d08f690cdcc00b4f9ff068a0550a9d" + integrity sha512-/RCYvStp6326SgK8JQVPlu48vt3tzTOM8XggXUtekTBLc1Q6wXyACSurQk7vQPuAt+l0Lk93734aFoDcC1W59A== dependencies: "@angular-devkit/architect" "^0.1301.0" - "@angular-devkit/core" "^13.0.0 || ^14.0.0" - "@angular-devkit/schematics" "^13.0.0 || ^14.0.0" - "@schematics/angular" "^13.0.0 || ^14.0.0" - xliff-simple-merge "~0.12.4" + "@angular-devkit/core" "^13.0.0 || ^14.0.0 || ^15.0.0" + "@angular-devkit/schematics" "^13.0.0 || ^14.0.0 || ^15.0.0" + "@schematics/angular" "^13.0.0 || ^14.0.0 || ^15.0.0" + xliff-simple-merge "~1.0.1" xml_normalize "~0.8.4" xmldoc "~1.1.2" @@ -21554,10 +21554,10 @@ x-default-browser@^0.4.0: optionalDependencies: default-browser-id "^1.0.4" -xliff-simple-merge@~0.12.4: - version "0.12.4" - resolved "https://registry.npmjs.org/xliff-simple-merge/-/xliff-simple-merge-0.12.4.tgz" - integrity sha512-Rk88D62XUoMgyBLEILpgOx3ARnxONLwH/xz+/c1HsRHYPHDnuZhYORkwrBCXsE942esG+J+OUCCOiydXJxY4Ug== +xliff-simple-merge@~1.0.1: + version "1.0.2" + resolved "https://registry.yarnpkg.com/xliff-simple-merge/-/xliff-simple-merge-1.0.2.tgz#55f88a84630de625db2b3ddfc3d0d741ac940bfd" + integrity sha512-9Dtw/l91o0DeLkNFJrlh5nxJSS8OD+IHeq5rjA6hkVtv6SWf7rJyr4YNSQc/6opDssRI8JgAWcQlj2ZfcvW11Q== dependencies: commander "~8.3.0" js-levenshtein "~1.1.6"