From aef14a3d050110fb2814ea66596a1eb47b7862a3 Mon Sep 17 00:00:00 2001 From: Horvath-Fabian <146414748+Horvath-Fabian@users.noreply.github.com> Date: Tue, 14 Apr 2026 19:50:51 +0200 Subject: [PATCH] Task/eliminate OnDestroy lifecycle hook from FAQ overview page component (#6734) Eliminate OnDestroy lifecycle hook --- .../faq/overview/faq-overview-page.component.ts | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/apps/client/src/app/pages/faq/overview/faq-overview-page.component.ts b/apps/client/src/app/pages/faq/overview/faq-overview-page.component.ts index 8faa8307e..1d59e67e8 100644 --- a/apps/client/src/app/pages/faq/overview/faq-overview-page.component.ts +++ b/apps/client/src/app/pages/faq/overview/faq-overview-page.component.ts @@ -7,11 +7,11 @@ import { ChangeDetectorRef, Component, CUSTOM_ELEMENTS_SCHEMA, - OnDestroy + DestroyRef } from '@angular/core'; +import { takeUntilDestroyed } from '@angular/core/rxjs-interop'; import { MatCardModule } from '@angular/material/card'; import { RouterModule } from '@angular/router'; -import { Subject, takeUntil } from 'rxjs'; @Component({ host: { class: 'page' }, @@ -21,21 +21,20 @@ import { Subject, takeUntil } from 'rxjs'; styleUrls: ['./faq-overview-page.scss'], templateUrl: './faq-overview-page.html' }) -export class GfFaqOverviewPageComponent implements OnDestroy { +export class GfFaqOverviewPageComponent { public pricingUrl = `https://ghostfol.io/${document.documentElement.lang}/${publicRoutes.pricing.path}`; public routerLinkFeatures = publicRoutes.features.routerLink; public user: User; - private unsubscribeSubject = new Subject(); - public constructor( private changeDetectorRef: ChangeDetectorRef, + private destroyRef: DestroyRef, private userService: UserService ) {} public ngOnInit() { this.userService.stateChanged - .pipe(takeUntil(this.unsubscribeSubject)) + .pipe(takeUntilDestroyed(this.destroyRef)) .subscribe((state) => { if (state?.user) { this.user = state.user; @@ -44,9 +43,4 @@ export class GfFaqOverviewPageComponent implements OnDestroy { } }); } - - public ngOnDestroy() { - this.unsubscribeSubject.next(); - this.unsubscribeSubject.complete(); - } }