From af5545f99b90ac0bda3ecf8d7f26c41475fa49c3 Mon Sep 17 00:00:00 2001 From: Madhab Sahoo Date: Sat, 28 Sep 2024 07:04:04 +0530 Subject: [PATCH] Changes updated as per the latest suggestions --- .../create-asset-profile-dialog.component.ts | 26 ++++++++++--------- .../create-asset-profile-dialog.html | 21 +++++++-------- package.json | 2 +- 3 files changed, 24 insertions(+), 25 deletions(-) diff --git a/apps/client/src/app/components/admin-market-data/create-asset-profile-dialog/create-asset-profile-dialog.component.ts b/apps/client/src/app/components/admin-market-data/create-asset-profile-dialog/create-asset-profile-dialog.component.ts index f1e20ec04..171dfab21 100644 --- a/apps/client/src/app/components/admin-market-data/create-asset-profile-dialog/create-asset-profile-dialog.component.ts +++ b/apps/client/src/app/components/admin-market-data/create-asset-profile-dialog/create-asset-profile-dialog.component.ts @@ -45,6 +45,20 @@ export class CreateAssetProfileDialog implements OnInit, OnDestroy { public readonly formBuilder: FormBuilder ) {} + public get showCurrencyErrorMessage() { + const addCurrencyFormControl = + this.createAssetProfileForm.get('addCurrency'); + + if ( + addCurrencyFormControl.hasError('minlength') || + addCurrencyFormControl.hasError('maxlength') + ) { + return true; + } + + return false; + } + public ngOnInit() { this.fetchAdminData(); @@ -153,16 +167,4 @@ export class CreateAssetProfileDialog implements OnInit, OnDestroy { }, 300); }); } - - get showCurrencyErrorMessage() { - const addCurrencyFormControl = - this.createAssetProfileForm.get('addCurrency'); - if ( - addCurrencyFormControl.hasError('minlength') || - addCurrencyFormControl.hasError('maxlength') - ) { - return true; - } - return false; - } } diff --git a/apps/client/src/app/components/admin-market-data/create-asset-profile-dialog/create-asset-profile-dialog.html b/apps/client/src/app/components/admin-market-data/create-asset-profile-dialog/create-asset-profile-dialog.html index 119ca050f..aaacd76e6 100644 --- a/apps/client/src/app/components/admin-market-data/create-asset-profile-dialog/create-asset-profile-dialog.html +++ b/apps/client/src/app/components/admin-market-data/create-asset-profile-dialog/create-asset-profile-dialog.html @@ -45,18 +45,15 @@ Currency - - Currency is required. - - - {{ createAssetProfileForm.controls['addCurrency'].value }} is an - invalid currency! Should be of 3 characters only. - + @if (createAssetProfileForm.get('addCurrency').hasError('required')) { + Currency is required. + } + @if (showCurrencyErrorMessage) { + + {{ createAssetProfileForm.controls['addCurrency'].value }} is an + invalid currency! Should be of 3 characters only. + + } } diff --git a/package.json b/package.json index cc55bcff1..6b1c1a09b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "ghostfolio", - "version": "2.111.0", + "version": "2.110.0", "homepage": "https://ghostfol.io", "license": "AGPL-3.0", "repository": "https://github.com/ghostfolio/ghostfolio",