From b2b819ebad471719d3f18a146deac47f32c1687b Mon Sep 17 00:00:00 2001
From: Kenrick Tandrian <60643640+KenTandrian@users.noreply.github.com>
Date: Thu, 26 Feb 2026 17:54:15 +0000
Subject: [PATCH] fix(lib): resolve typescript errors in portfolio filter form

---
 .../portfolio-filter-form.component.ts            | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts
index afbe5af4e..2fcfe00f0 100644
--- a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts
+++ b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts
@@ -61,7 +61,12 @@ export class GfPortfolioFilterFormComponent
   @Input() tags: Filter[] = [];
   @Input() disabled = false;
 
-  public filterForm: FormGroup;
+  public filterForm: FormGroup<{
+    account: FormControl<string | null>;
+    assetClass: FormControl<string | null>;
+    holding: FormControl<PortfolioPosition | null>;
+    tag: FormControl<string | null>;
+  }>;
 
   private unsubscribeSubject = new Subject<void>();
 
@@ -70,10 +75,10 @@ export class GfPortfolioFilterFormComponent
     private formBuilder: FormBuilder
   ) {
     this.filterForm = this.formBuilder.group({
-      account: new FormControl<string>(null),
-      assetClass: new FormControl<string>(null),
-      holding: new FormControl<PortfolioPosition>(null),
-      tag: new FormControl<string>(null)
+      account: new FormControl<string | null>(null),
+      assetClass: new FormControl<string | null>(null),
+      holding: new FormControl<PortfolioPosition | null>(null),
+      tag: new FormControl<string | null>(null)
     });
   }