From b333ec6b59d20dfbed8a402c27bdf3ee33b34c2f Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sun, 7 Sep 2025 10:14:17 +0200
Subject: [PATCH] Remove redundant currency

---
 apps/api/src/app/order/order.service.ts                   | 8 +++++++-
 .../migration.sql                                         | 5 +++++
 2 files changed, 12 insertions(+), 1 deletion(-)
 create mode 100644 prisma/migrations/20250907093545_removed_redundant_currency_from_order/migration.sql

diff --git a/apps/api/src/app/order/order.service.ts b/apps/api/src/app/order/order.service.ts
index fd50f5e74..13e00e0ff 100644
--- a/apps/api/src/app/order/order.service.ts
+++ b/apps/api/src/app/order/order.service.ts
@@ -95,7 +95,6 @@ export class OrderService {
       accountId?: string;
       assetClass?: AssetClass;
       assetSubClass?: AssetSubClass;
-      currency?: string;
       symbol?: string;
       tags?: { id: string }[];
       updateAccountBalance?: boolean;
@@ -184,6 +183,10 @@ export class OrderService {
       delete data.comment;
     }
 
+    if (data.currency === data.SymbolProfile.connectOrCreate.create.currency) {
+      delete data.currency;
+    }
+
     delete data.symbol;
     delete data.tags;
     delete data.updateAccountBalance;
@@ -703,6 +706,9 @@ export class OrderService {
 
     delete data.assetClass;
     delete data.assetSubClass;
+
+    // TODO: Remove currency?
+
     delete data.symbol;
     delete data.tags;
 
diff --git a/prisma/migrations/20250907093545_removed_redundant_currency_from_order/migration.sql b/prisma/migrations/20250907093545_removed_redundant_currency_from_order/migration.sql
new file mode 100644
index 000000000..b71780e19
--- /dev/null
+++ b/prisma/migrations/20250907093545_removed_redundant_currency_from_order/migration.sql
@@ -0,0 +1,5 @@
+-- Remove redundant currency from the 'Order' table
+UPDATE "Order"
+SET "currency" = NULL
+FROM "SymbolProfile"
+WHERE "Order"."symbolProfileId" = "SymbolProfile"."id" AND "Order"."currency" = "SymbolProfile"."currency";