From b40e3683f41878b8b6e72218471f1bf083e9e065 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marcin=20Szyma=C5=84ski?= <ms32035@gmail.com>
Date: Fri, 2 May 2025 19:44:27 +0100
Subject: [PATCH] switch to Promise.all

---
 apps/api/src/app/order/order.service.ts | 64 ++++++++++++++-----------
 1 file changed, 36 insertions(+), 28 deletions(-)

diff --git a/apps/api/src/app/order/order.service.ts b/apps/api/src/app/order/order.service.ts
index 8b41600db..739d48b51 100644
--- a/apps/api/src/app/order/order.service.ts
+++ b/apps/api/src/app/order/order.service.ts
@@ -531,38 +531,46 @@ export class OrderService {
 
         const value = new Big(order.quantity).mul(order.unitPrice).toNumber();
 
+        const [
+          feeInAssetProfileCurrency,
+          feeInBaseCurrency,
+          unitPriceInAssetProfileCurrency,
+          valueInBaseCurrency
+        ] = await Promise.all([
+          this.exchangeRateDataService.toCurrencyAtDate(
+            order.fee,
+            order.currency ?? order.SymbolProfile.currency,
+            order.SymbolProfile.currency,
+            order.date
+          ),
+          this.exchangeRateDataService.toCurrencyAtDate(
+            order.fee,
+            order.currency ?? order.SymbolProfile.currency,
+            userCurrency,
+            order.date
+          ),
+          this.exchangeRateDataService.toCurrencyAtDate(
+            order.unitPrice,
+            order.currency ?? order.SymbolProfile.currency,
+            order.SymbolProfile.currency,
+            order.date
+          ),
+          this.exchangeRateDataService.toCurrencyAtDate(
+            value,
+            order.currency ?? order.SymbolProfile.currency,
+            userCurrency,
+            order.date
+          )
+        ]);
+
         return {
           ...order,
           value,
-          feeInAssetProfileCurrency:
-            await this.exchangeRateDataService.toCurrencyAtDate(
-              order.fee,
-              order.currency ?? order.SymbolProfile.currency,
-              order.SymbolProfile.currency,
-              order.date
-            ),
-          feeInBaseCurrency:
-            await this.exchangeRateDataService.toCurrencyAtDate(
-              order.fee,
-              order.currency ?? order.SymbolProfile.currency,
-              userCurrency,
-              order.date
-            ),
+          feeInAssetProfileCurrency,
+          feeInBaseCurrency,
           SymbolProfile: assetProfile,
-          unitPriceInAssetProfileCurrency:
-            await this.exchangeRateDataService.toCurrencyAtDate(
-              order.unitPrice,
-              order.currency ?? order.SymbolProfile.currency,
-              order.SymbolProfile.currency,
-              order.date
-            ),
-          valueInBaseCurrency:
-            await this.exchangeRateDataService.toCurrencyAtDate(
-              value,
-              order.currency ?? order.SymbolProfile.currency,
-              userCurrency,
-              order.date
-            )
+          unitPriceInAssetProfileCurrency,
+          valueInBaseCurrency
         };
       })
     );