Refactoring

libs/common/src/lib/helper.spec.ts

@@ -29,6 +29,10 @@ describe('Helper', () => {
       );
     });
 
+    it('Get decimal number (with hyphenated text)', () => {
+      expect(extractNumberFromString({ value: 'BRK-B 425.30' })).toEqual(425.3);
+    });
+
     it('Get decimal number (comma notation)', () => {
       expect(
         extractNumberFromString({ locale: 'de-DE', value: '999,99' })

libs/common/src/lib/helper.ts

@@ -210,13 +210,17 @@ export function extractNumberFromString({
   value: string;
 }): number | undefined {
   try {
-    // Remove non-numeric characters (excluding international formatting
+    // Only a leading minus sign indicates a negative value. Detect it before
-    // characters and the minus sign to preserve negative values)
+    // stripping so that hyphens within the text cannot flip the sign.
-    const numericValue = value.replace(/[^\d.,'’\s-]/g, '');
+    const isNegative = value.trim().startsWith('-');
+
+    // Remove non-numeric characters (excluding international formatting characters)
+    const numericValue = value.replace(/[^\d.,'’\s]/g, '');
 
     const parser = new NumberParser(locale);
+    const parsedValue = parser.parse(numericValue);
 
-    return parser.parse(numericValue);
+    return isNegative ? -parsedValue : parsedValue;
   } catch {
     return undefined;
   }