From b63c6ec61ada0c522161171bf6068b046fffd694 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Mon, 20 Oct 2025 19:56:48 +0200 Subject: [PATCH] Minor improvements --- libs/ui/src/lib/assistant/assistant.html | 5 ++++- .../portfolio-filter-form.component.stories.ts | 13 +++++++++++-- .../portfolio-filter-form.component.ts | 1 + 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/libs/ui/src/lib/assistant/assistant.html b/libs/ui/src/lib/assistant/assistant.html index 96b1b2b08..e0a8f2fc9 100644 --- a/libs/ui/src/lib/assistant/assistant.html +++ b/libs/ui/src/lib/assistant/assistant.html @@ -172,7 +172,10 @@ [formControl]="dateRangeFormControl" (selectionChange)="onChangeDateRange($event.value)" > - @for (dateRangeOption of dateRangeOptions; track dateRangeOption) { + @for ( + dateRangeOption of dateRangeOptions; + track dateRangeOption.value + ) { {{ dateRangeOption.label }} diff --git a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.stories.ts b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.stories.ts index 1d55cefd9..710a4e9c5 100644 --- a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.stories.ts +++ b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.stories.ts @@ -1,3 +1,4 @@ +import '@angular/localize/init'; import { Meta, moduleMetadata, StoryObj } from '@storybook/angular'; import { GfPortfolioFilterFormComponent } from './portfolio-filter-form.component'; @@ -55,8 +56,16 @@ export const Default: Story = { } ] as any, tags: [ - { id: 'dividend', label: 'Dividend', type: 'TAG' }, - { id: 'tech', label: 'Technology', type: 'TAG' } + { + id: 'EMERGENCY_FUND', + label: 'Emergency Fund', + type: 'TAG' + }, + { + id: 'RETIREMENT_FUND', + label: 'Retirement Fund', + type: 'TAG' + } ] as any, disabled: false } diff --git a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts index 10f72d761..bc6de4d42 100644 --- a/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts +++ b/libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts @@ -120,6 +120,7 @@ export class GfPortfolioFilterFormComponent } const tagControl = this.filterForm.get('tag'); + if (this.tags.length === 0) { tagControl?.disable({ emitEvent: false }); } else if (!this.disabled) {