Harmonize sector names

apps/api/src/helper/sector.helper.ts

@@ -1,4 +1,5 @@
-import { SECTORS, UNKNOWN_KEY } from '@ghostfolio/common/config';
+import { SECTORS } from '@ghostfolio/common/config';
+import { SectorName } from '@ghostfolio/common/types';
 
 import { Logger } from '@nestjs/common';
 
@@ -6,9 +7,9 @@ export function getSectorName({
   aliases = {},
   name
 }: {
-  aliases?: Record<string, string>;
+  aliases?: Record<string, SectorName>;
   name: string;
-}): string {
+}): SectorName {
   const mappedName = aliases[name];
 
   if (mappedName) {
@@ -16,7 +17,7 @@ export function getSectorName({
   }
 
   if ((SECTORS as readonly string[]).includes(name)) {
-    return name;
+    return name as SectorName;
   }
 
   if (name) {
@@ -25,5 +26,5 @@ export function getSectorName({
     logger.warn(`Could not map the sector "${name}" to the ontology`);
   }
 
-  return UNKNOWN_KEY;
+  return 'Other';
 }

apps/client/src/app/pages/public/public-page.component.ts

@@ -9,6 +9,7 @@ import { hasPermission, permissions } from '@ghostfolio/common/permissions';
 import { Market } from '@ghostfolio/common/types';
 import { GfActivitiesTableComponent } from '@ghostfolio/ui/activities-table/activities-table.component';
 import { GfHoldingsTableComponent } from '@ghostfolio/ui/holdings-table/holdings-table.component';
+import { translate } from '@ghostfolio/ui/i18n';
 import { GfPortfolioProportionChartComponent } from '@ghostfolio/ui/portfolio-proportion-chart/portfolio-proportion-chart.component';
 import { DataService } from '@ghostfolio/ui/services';
 import { GfValueComponent } from '@ghostfolio/ui/value';
@@ -232,7 +233,7 @@ export class GfPublicPageComponent implements OnInit {
                 weight * (position.valueInBaseCurrency ?? 0);
             } else {
               this.sectors[name] = {
-                name,
+                name: translate(name),
                 value:
                   weight *
                   (this.publicPortfolioDetails.holdings[symbol]