From b7626f456b1961737b8465d06ebad2cb6de830e5 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sat, 24 Feb 2024 10:58:51 +0100
Subject: [PATCH] Improve value redaction in portfolio details endpoint

---
 apps/api/src/app/portfolio/portfolio.controller.ts           | 5 -----
 .../interceptors/redact-values-in-response.interceptor.ts    | 2 ++
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/apps/api/src/app/portfolio/portfolio.controller.ts b/apps/api/src/app/portfolio/portfolio.controller.ts
index 772ee3068..fc76a3144 100644
--- a/apps/api/src/app/portfolio/portfolio.controller.ts
+++ b/apps/api/src/app/portfolio/portfolio.controller.ts
@@ -135,13 +135,8 @@ export class PortfolioController {
         .reduce((a, b) => a + b, 0);
 
       for (const [symbol, portfolioPosition] of Object.entries(holdings)) {
-        portfolioPosition.grossPerformance = null;
-        portfolioPosition.grossPerformanceWithCurrencyEffect = null;
         portfolioPosition.investment =
           portfolioPosition.investment / totalInvestment;
-        portfolioPosition.netPerformance = null;
-        portfolioPosition.netPerformanceWithCurrencyEffect = null;
-        portfolioPosition.quantity = null;
         portfolioPosition.valueInPercentage =
           portfolioPosition.valueInBaseCurrency / totalValue;
       }
diff --git a/apps/api/src/interceptors/redact-values-in-response.interceptor.ts b/apps/api/src/interceptors/redact-values-in-response.interceptor.ts
index c1df8157e..b1889cf9d 100644
--- a/apps/api/src/interceptors/redact-values-in-response.interceptor.ts
+++ b/apps/api/src/interceptors/redact-values-in-response.interceptor.ts
@@ -51,8 +51,10 @@ export class RedactValuesInResponseInterceptor<T>
               'feeInBaseCurrency',
               'filteredValueInBaseCurrency',
               'grossPerformance',
+              'grossPerformanceWithCurrencyEffect',
               'investment',
               'netPerformance',
+              'netPerformanceWithCurrencyEffect',
               'quantity',
               'symbolMapping',
               'totalBalanceInBaseCurrency',