diff --git a/apps/api/src/models/rules/account-cluster-risk/current-investment.ts b/apps/api/src/models/rules/account-cluster-risk/current-investment.ts index e25bb2f08..13680270e 100644 --- a/apps/api/src/models/rules/account-cluster-risk/current-investment.ts +++ b/apps/api/src/models/rules/account-cluster-risk/current-investment.ts @@ -76,11 +76,11 @@ export class AccountClusterRiskCurrentInvestment extends Rule { }; } - public getSettings(aUserSettings: UserSettings): Settings { + public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { return { - baseCurrency: aUserSettings.baseCurrency, - isActive: aUserSettings.xRayRules[this.getKey()].isActive, - thresholdMax: 0.5 + baseCurrency, + isActive: xRayRules[this.getKey()].isActive, + thresholdMax: xRayRules[this.getKey()]?.thresholdMax ?? 0.5 }; } } diff --git a/apps/api/src/models/rules/account-cluster-risk/single-account.ts b/apps/api/src/models/rules/account-cluster-risk/single-account.ts index 1f61b9659..feaaf4e38 100644 --- a/apps/api/src/models/rules/account-cluster-risk/single-account.ts +++ b/apps/api/src/models/rules/account-cluster-risk/single-account.ts @@ -34,9 +34,9 @@ export class AccountClusterRiskSingleAccount extends Rule { }; } - public getSettings(aUserSettings: UserSettings): RuleSettings { + public getSettings({ xRayRules }: UserSettings): RuleSettings { return { - isActive: aUserSettings.xRayRules[this.getKey()].isActive + isActive: xRayRules[this.getKey()].isActive }; } } diff --git a/apps/api/src/models/rules/currency-cluster-risk/base-currency-current-investment.ts b/apps/api/src/models/rules/currency-cluster-risk/base-currency-current-investment.ts index 1258eb889..e3050efcc 100644 --- a/apps/api/src/models/rules/currency-cluster-risk/base-currency-current-investment.ts +++ b/apps/api/src/models/rules/currency-cluster-risk/base-currency-current-investment.ts @@ -62,10 +62,10 @@ export class CurrencyClusterRiskBaseCurrencyCurrentInvestment extends Rule { }; } - public getSettings(aUserSettings: UserSettings): Settings { + public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { return { - baseCurrency: aUserSettings.baseCurrency, - isActive: aUserSettings.xRayRules[this.getKey()].isActive, - thresholdMax: 0.5 + baseCurrency, + isActive: xRayRules[this.getKey()].isActive, + thresholdMax: xRayRules[this.getKey()]?.thresholdMax ?? 0.5 }; } } diff --git a/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts b/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts index 0ba7a109c..c59701438 100644 --- a/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts +++ b/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts @@ -19,7 +19,7 @@ export class EmergencyFundSetup extends Rule { } public evaluate(ruleSettings: Settings) { - if (this.emergencyFund < ruleSettings.thresholdMin) { + if (!this.emergencyFund) { return { evaluation: 'No emergency fund has been set up', value: false @@ -32,16 +32,14 @@ export class EmergencyFundSetup extends Rule { }; } - public getSettings(aUserSettings: UserSettings): Settings { + public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { return { - baseCurrency: aUserSettings.baseCurrency, - isActive: aUserSettings.xRayRules[this.getKey()].isActive, - thresholdMin: 0 + baseCurrency, + isActive: xRayRules[this.getKey()].isActive }; } } interface Settings extends RuleSettings { baseCurrency: string; - thresholdMin: number; } diff --git a/apps/api/src/models/rules/fees/fee-ratio-initial-investment.ts b/apps/api/src/models/rules/fees/fee-ratio-initial-investment.ts index 09029fd3e..9b1961ed6 100644 --- a/apps/api/src/models/rules/fees/fee-ratio-initial-investment.ts +++ b/apps/api/src/models/rules/fees/fee-ratio-initial-investment.ts @@ -43,11 +43,11 @@ export class FeeRatioInitialInvestment extends Rule { }; } - public getSettings(aUserSettings: UserSettings): Settings { + public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { return { - baseCurrency: aUserSettings.baseCurrency, - isActive: aUserSettings.xRayRules[this.getKey()].isActive, - thresholdMax: 0.01 + baseCurrency, + isActive: xRayRules[this.getKey()].isActive, + thresholdMax: xRayRules[this.getKey()]?.thresholdMax ?? 0.01 }; } } diff --git a/apps/client/src/app/pages/portfolio/fire/fire-page.component.ts b/apps/client/src/app/pages/portfolio/fire/fire-page.component.ts index 5aca4b375..10a2eb604 100644 --- a/apps/client/src/app/pages/portfolio/fire/fire-page.component.ts +++ b/apps/client/src/app/pages/portfolio/fire/fire-page.component.ts @@ -134,8 +134,6 @@ export class FirePageComponent implements OnDestroy, OnInit { } public onRulesUpdated(event: UpdateUserSettingDto) { - this.isLoading = true; - this.dataService .putUserSetting(event) .pipe(takeUntil(this.unsubscribeSubject))