diff --git a/apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.controller.ts b/apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.controller.ts index 1d1deb7f8..58a3224c1 100644 --- a/apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.controller.ts +++ b/apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.controller.ts @@ -1,7 +1,5 @@ import { HasPermission } from '@ghostfolio/api/decorators/has-permission.decorator'; import { HasPermissionGuard } from '@ghostfolio/api/guards/has-permission.guard'; -import { PropertyService } from '@ghostfolio/api/services/property/property.service'; -import { PROPERTY_API_KEY_GHOSTFOLIO } from '@ghostfolio/common/config'; import { parseDate } from '@ghostfolio/common/helper'; import { DataProviderGhostfolioStatusResponse, @@ -33,7 +31,6 @@ import { GhostfolioService } from './ghostfolio.service'; export class GhostfolioController { public constructor( private readonly ghostfolioService: GhostfolioService, - private readonly propertyService: PropertyService, @Inject(REQUEST) private readonly request: RequestWithUser ) {} @@ -153,17 +150,6 @@ export class GhostfolioController { @HasPermission(permissions.enableDataProviderGhostfolio) @UseGuards(AuthGuard('jwt'), HasPermissionGuard) public async getStatus(): Promise { - const ghostfolioApiKey = (await this.propertyService.getByKey( - PROPERTY_API_KEY_GHOSTFOLIO - )) as string; - - if (!ghostfolioApiKey) { - throw new HttpException( - getReasonPhrase(StatusCodes.SERVICE_UNAVAILABLE), - StatusCodes.SERVICE_UNAVAILABLE - ); - } - return { dailyRequests: this.request.user.dataProviderGhostfolioDailyRequests, dailyRequestsMax: await this.ghostfolioService.getMaxDailyRequests() diff --git a/apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.service.ts b/apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.service.ts index e77279d75..52baa10d6 100644 --- a/apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.service.ts +++ b/apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.service.ts @@ -202,11 +202,11 @@ export class GhostfolioService { const searchResults = await Promise.all(promises); - searchResults.forEach(({ items }) => { + for (const { items } of searchResults) { if (items?.length > 0) { lookupItems = lookupItems.concat(items); } - }); + } const filteredItems = lookupItems .filter(({ currency }) => { diff --git a/apps/api/src/services/data-provider/data-provider.service.ts b/apps/api/src/services/data-provider/data-provider.service.ts index 50d14be89..3faf5b583 100644 --- a/apps/api/src/services/data-provider/data-provider.service.ts +++ b/apps/api/src/services/data-provider/data-provider.service.ts @@ -625,11 +625,11 @@ export class DataProviderService { const searchResults = await Promise.all(promises); - searchResults.forEach(({ items }) => { + for (const { items } of searchResults) { if (items?.length > 0) { lookupItems = lookupItems.concat(items); } - }); + } const filteredItems = lookupItems .filter(({ currency }) => { diff --git a/apps/client/src/app/components/admin-settings/admin-settings.component.html b/apps/client/src/app/components/admin-settings/admin-settings.component.html index 2cd6072f1..35ed556b6 100644 --- a/apps/client/src/app/components/admin-settings/admin-settings.component.html +++ b/apps/client/src/app/components/admin-settings/admin-settings.component.html @@ -11,7 +11,7 @@ target="_blank" [href]="pricingUrl" > - @if (hasGhostfolioApiKey === false) { + @if (isGhostfolioApiKeyValid === false) { NEW } Ghostfolio Premium @@ -22,7 +22,7 @@
- @if (hasGhostfolioApiKey === true) { + @if (isGhostfolioApiKeyValid === true) {
{{ ghostfolioApiStatus.dailyRequests }} @@ -38,7 +38,7 @@ Remove API key
- } @else if (hasGhostfolioApiKey === false) { + } @else if (isGhostfolioApiKeyValid === false) {