Browse Source

Move holding valuation of portfolio calculator to base class

pull/7917/head
Thomas Kaul 4 weeks ago
parent
commit
bbbcd70778
  1. 2
      apps/api/src/app/portfolio/calculator/portfolio-calculator.ts
  2. 4
      apps/api/src/app/portfolio/interfaces/holding-valuation-item.interface.ts
  3. 4
      apps/api/src/app/portfolio/interfaces/holding-valuation.interface.ts

2
apps/api/src/app/portfolio/calculator/portfolio-calculator.ts

@ -928,7 +928,7 @@ export abstract class PortfolioCalculator {
}: {
activities: PortfolioCalculatorActivityItem[];
exchangeRates: { [dateString: string]: number };
unitPriceAtStartDate: Big;
unitPriceAtStartDate: Big | undefined;
}): HoldingValuation {
const currentExchangeRate = exchangeRates[format(new Date(), DATE_FORMAT)];
const currentValues: { [date: string]: Big } = {};

4
apps/api/src/app/portfolio/interfaces/holding-valuation-item.interface.ts

@ -1,7 +1,7 @@
import { PortfolioCalculatorActivityItem } from '@ghostfolio/api/app/portfolio/interfaces/portfolio-calculator-activity-item.interface';
import { Big } from 'big.js';
import { PortfolioCalculatorActivityItem } from './portfolio-calculator-activity-item.interface';
export interface HoldingValuationItem extends Pick<
PortfolioCalculatorActivityItem,
'date' | 'itemType' | 'type'

4
apps/api/src/app/portfolio/interfaces/holding-valuation.interface.ts

@ -1,7 +1,7 @@
import { HoldingValuationItem } from '@ghostfolio/api/app/portfolio/interfaces/holding-valuation-item.interface';
import { Big } from 'big.js';
import { HoldingValuationItem } from './holding-valuation-item.interface';
export interface HoldingValuation {
currentValues: { [date: string]: Big };
currentValuesWithCurrencyEffect: { [date: string]: Big };

Loading…
Cancel
Save