Refactoring

apps/api/src/app/portfolio/portfolio.controller.ts

@@ -117,7 +117,6 @@ export class PortfolioController {
       hasReadRestrictedAccessPermission ||
       this.userService.isRestrictedView(this.request.user)
     ) {
-      // TODO: Introduce calculations with currency effect
       const totalInvestment = Object.values(holdings)
         .map(({ investment }) => {
           return investment;
@@ -125,12 +124,11 @@ export class PortfolioController {
         .reduce((a, b) => a + b, 0);
 
       const totalValue = Object.values(holdings)
-        .map(({ currency, marketPrice, quantity }) => {
+        .filter(({ assetClass, assetSubClass }) => {
-          return this.exchangeRateDataService.toCurrency(
+          return assetClass !== 'CASH' && assetSubClass !== 'CASH';
-            quantity * marketPrice,
+        })
-            currency,
+        .map(({ valueInBaseCurrency }) => {
-            this.request.user.Settings.settings.baseCurrency
+          return valueInBaseCurrency;
-          );
         })
         .reduce((a, b) => a + b, 0);