From c01d89a2d89c70cf344124535453ca79b6e20d74 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Tue, 28 Apr 2026 20:50:45 +0200
Subject: [PATCH] Extract page tabs

---
 .../src/app/pages/about/about-page.component.ts |  7 +++++--
 .../src/app/pages/admin/admin-page.component.ts |  6 ++++--
 .../src/app/pages/faq/faq-page.component.ts     |  6 ++++--
 .../src/app/pages/home/home-page.component.ts   |  7 +++++--
 .../pages/portfolio/portfolio-page.component.ts |  7 +++++--
 .../pages/resources/resources-page.component.ts |  6 ++++--
 .../user-account/user-account-page.component.ts |  7 +++++--
 .../src/app/pages/zen/zen-page.component.ts     |  7 +++++--
 libs/common/src/lib/interfaces/index.ts         |  2 --
 libs/ui/src/lib/page-tabs/index.ts              |  1 +
 .../src/lib/page-tabs/interfaces/interfaces.ts} |  0
 .../ui/src/lib/page-tabs/page-tabs.component.ts | 17 ++++++++++++-----
 12 files changed, 50 insertions(+), 23 deletions(-)
 rename libs/{common/src/lib/interfaces/tab-configuration.interface.ts => ui/src/lib/page-tabs/interfaces/interfaces.ts} (100%)

diff --git a/apps/client/src/app/pages/about/about-page.component.ts b/apps/client/src/app/pages/about/about-page.component.ts
index 5ff2bc74c..fb632a586 100644
--- a/apps/client/src/app/pages/about/about-page.component.ts
+++ b/apps/client/src/app/pages/about/about-page.component.ts
@@ -1,8 +1,11 @@
 import { UserService } from '@ghostfolio/client/services/user/user.service';
-import { TabConfiguration, User } from '@ghostfolio/common/interfaces';
+import { User } from '@ghostfolio/common/interfaces';
 import { hasPermission, permissions } from '@ghostfolio/common/permissions';
 import { publicRoutes } from '@ghostfolio/common/routes/routes';
-import { GfPageTabsComponent } from '@ghostfolio/ui/page-tabs';
+import {
+  GfPageTabsComponent,
+  TabConfiguration
+} from '@ghostfolio/ui/page-tabs';
 import { DataService } from '@ghostfolio/ui/services';
 
 import { ChangeDetectorRef, Component, DestroyRef } from '@angular/core';
diff --git a/apps/client/src/app/pages/admin/admin-page.component.ts b/apps/client/src/app/pages/admin/admin-page.component.ts
index 55790ce74..6b653efb0 100644
--- a/apps/client/src/app/pages/admin/admin-page.component.ts
+++ b/apps/client/src/app/pages/admin/admin-page.component.ts
@@ -1,6 +1,8 @@
-import { TabConfiguration } from '@ghostfolio/common/interfaces';
 import { internalRoutes } from '@ghostfolio/common/routes/routes';
-import { GfPageTabsComponent } from '@ghostfolio/ui/page-tabs';
+import {
+  GfPageTabsComponent,
+  TabConfiguration
+} from '@ghostfolio/ui/page-tabs';
 
 import { Component, OnInit } from '@angular/core';
 import { addIcons } from 'ionicons';
diff --git a/apps/client/src/app/pages/faq/faq-page.component.ts b/apps/client/src/app/pages/faq/faq-page.component.ts
index afe2a7684..6dabdb5e2 100644
--- a/apps/client/src/app/pages/faq/faq-page.component.ts
+++ b/apps/client/src/app/pages/faq/faq-page.component.ts
@@ -1,7 +1,9 @@
-import { TabConfiguration } from '@ghostfolio/common/interfaces';
 import { hasPermission, permissions } from '@ghostfolio/common/permissions';
 import { publicRoutes } from '@ghostfolio/common/routes/routes';
-import { GfPageTabsComponent } from '@ghostfolio/ui/page-tabs';
+import {
+  GfPageTabsComponent,
+  TabConfiguration
+} from '@ghostfolio/ui/page-tabs';
 import { DataService } from '@ghostfolio/ui/services';
 
 import { Component } from '@angular/core';
diff --git a/apps/client/src/app/pages/home/home-page.component.ts b/apps/client/src/app/pages/home/home-page.component.ts
index 81e456636..453a79a52 100644
--- a/apps/client/src/app/pages/home/home-page.component.ts
+++ b/apps/client/src/app/pages/home/home-page.component.ts
@@ -1,9 +1,12 @@
 import { ImpersonationStorageService } from '@ghostfolio/client/services/impersonation-storage.service';
 import { UserService } from '@ghostfolio/client/services/user/user.service';
-import { TabConfiguration, User } from '@ghostfolio/common/interfaces';
+import { User } from '@ghostfolio/common/interfaces';
 import { hasPermission, permissions } from '@ghostfolio/common/permissions';
 import { internalRoutes } from '@ghostfolio/common/routes/routes';
-import { GfPageTabsComponent } from '@ghostfolio/ui/page-tabs';
+import {
+  GfPageTabsComponent,
+  TabConfiguration
+} from '@ghostfolio/ui/page-tabs';
 
 import {
   ChangeDetectorRef,
diff --git a/apps/client/src/app/pages/portfolio/portfolio-page.component.ts b/apps/client/src/app/pages/portfolio/portfolio-page.component.ts
index 909610ac9..00fb3242b 100644
--- a/apps/client/src/app/pages/portfolio/portfolio-page.component.ts
+++ b/apps/client/src/app/pages/portfolio/portfolio-page.component.ts
@@ -1,7 +1,10 @@
 import { UserService } from '@ghostfolio/client/services/user/user.service';
-import { TabConfiguration, User } from '@ghostfolio/common/interfaces';
+import { User } from '@ghostfolio/common/interfaces';
 import { internalRoutes } from '@ghostfolio/common/routes/routes';
-import { GfPageTabsComponent } from '@ghostfolio/ui/page-tabs';
+import {
+  GfPageTabsComponent,
+  TabConfiguration
+} from '@ghostfolio/ui/page-tabs';
 
 import { ChangeDetectorRef, Component, DestroyRef } from '@angular/core';
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
diff --git a/apps/client/src/app/pages/resources/resources-page.component.ts b/apps/client/src/app/pages/resources/resources-page.component.ts
index 0e4fa59c6..faba06f28 100644
--- a/apps/client/src/app/pages/resources/resources-page.component.ts
+++ b/apps/client/src/app/pages/resources/resources-page.component.ts
@@ -1,6 +1,8 @@
-import { TabConfiguration } from '@ghostfolio/common/interfaces';
 import { publicRoutes } from '@ghostfolio/common/routes/routes';
-import { GfPageTabsComponent } from '@ghostfolio/ui/page-tabs';
+import {
+  GfPageTabsComponent,
+  TabConfiguration
+} from '@ghostfolio/ui/page-tabs';
 
 import { Component } from '@angular/core';
 import { addIcons } from 'ionicons';
diff --git a/apps/client/src/app/pages/user-account/user-account-page.component.ts b/apps/client/src/app/pages/user-account/user-account-page.component.ts
index 51f35368b..71b93b2e4 100644
--- a/apps/client/src/app/pages/user-account/user-account-page.component.ts
+++ b/apps/client/src/app/pages/user-account/user-account-page.component.ts
@@ -1,7 +1,10 @@
 import { UserService } from '@ghostfolio/client/services/user/user.service';
-import { TabConfiguration, User } from '@ghostfolio/common/interfaces';
+import { User } from '@ghostfolio/common/interfaces';
 import { internalRoutes } from '@ghostfolio/common/routes/routes';
-import { GfPageTabsComponent } from '@ghostfolio/ui/page-tabs';
+import {
+  GfPageTabsComponent,
+  TabConfiguration
+} from '@ghostfolio/ui/page-tabs';
 
 import { ChangeDetectorRef, Component, DestroyRef } from '@angular/core';
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
diff --git a/apps/client/src/app/pages/zen/zen-page.component.ts b/apps/client/src/app/pages/zen/zen-page.component.ts
index 53223cca6..df3684fd2 100644
--- a/apps/client/src/app/pages/zen/zen-page.component.ts
+++ b/apps/client/src/app/pages/zen/zen-page.component.ts
@@ -1,7 +1,10 @@
 import { UserService } from '@ghostfolio/client/services/user/user.service';
-import { TabConfiguration, User } from '@ghostfolio/common/interfaces';
+import { User } from '@ghostfolio/common/interfaces';
 import { internalRoutes } from '@ghostfolio/common/routes/routes';
-import { GfPageTabsComponent } from '@ghostfolio/ui/page-tabs';
+import {
+  GfPageTabsComponent,
+  TabConfiguration
+} from '@ghostfolio/ui/page-tabs';
 
 import { ChangeDetectorRef, Component, DestroyRef } from '@angular/core';
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
diff --git a/libs/common/src/lib/interfaces/index.ts b/libs/common/src/lib/interfaces/index.ts
index 89874da60..536fc0feb 100644
--- a/libs/common/src/lib/interfaces/index.ts
+++ b/libs/common/src/lib/interfaces/index.ts
@@ -91,7 +91,6 @@ import type { SubscriptionOffer } from './subscription-offer.interface';
 import type { SymbolItem } from './symbol-item.interface';
 import type { SymbolMetrics } from './symbol-metrics.interface';
 import type { SystemMessage } from './system-message.interface';
-import type { TabConfiguration } from './tab-configuration.interface';
 import type { ToggleOption } from './toggle-option.interface';
 import type { UserItem } from './user-item.interface';
 import type { UserSettings } from './user-settings.interface';
@@ -186,7 +185,6 @@ export {
   SymbolItem,
   SymbolMetrics,
   SystemMessage,
-  TabConfiguration,
   ToggleOption,
   User,
   UserItem,
diff --git a/libs/ui/src/lib/page-tabs/index.ts b/libs/ui/src/lib/page-tabs/index.ts
index 76df72f89..a7b3468fd 100644
--- a/libs/ui/src/lib/page-tabs/index.ts
+++ b/libs/ui/src/lib/page-tabs/index.ts
@@ -1 +1,2 @@
+export * from './interfaces/interfaces';
 export * from './page-tabs.component';
diff --git a/libs/common/src/lib/interfaces/tab-configuration.interface.ts b/libs/ui/src/lib/page-tabs/interfaces/interfaces.ts
similarity index 100%
rename from libs/common/src/lib/interfaces/tab-configuration.interface.ts
rename to libs/ui/src/lib/page-tabs/interfaces/interfaces.ts
diff --git a/libs/ui/src/lib/page-tabs/page-tabs.component.ts b/libs/ui/src/lib/page-tabs/page-tabs.component.ts
index e2f1059f9..61c2caf05 100644
--- a/libs/ui/src/lib/page-tabs/page-tabs.component.ts
+++ b/libs/ui/src/lib/page-tabs/page-tabs.component.ts
@@ -1,11 +1,16 @@
-import { TabConfiguration } from '@ghostfolio/common/interfaces';
-
-import { ChangeDetectionStrategy, Component, input } from '@angular/core';
+import {
+  ChangeDetectionStrategy,
+  Component,
+  inject,
+  input
+} from '@angular/core';
 import { MatTabsModule } from '@angular/material/tabs';
 import { RouterModule } from '@angular/router';
 import { IonIcon } from '@ionic/angular/standalone';
 import { DeviceDetectorService } from 'ngx-device-detector';
 
+import { TabConfiguration } from './interfaces/interfaces';
+
 @Component({
   changeDetection: ChangeDetectionStrategy.OnPush,
   imports: [IonIcon, MatTabsModule, RouterModule],
@@ -17,7 +22,9 @@ export class GfPageTabsComponent {
   public deviceType: string;
   public readonly tabs = input.required<TabConfiguration[]>();
 
-  public constructor(deviceService: DeviceDetectorService) {
-    this.deviceType = deviceService.getDeviceInfo().deviceType;
+  private readonly deviceService = inject(DeviceDetectorService);
+
+  public constructor() {
+    this.deviceType = this.deviceService.getDeviceInfo().deviceType;
   }
 }