From 4d79df90a735abd0acc06104724502380a737da2 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Wed, 20 Dec 2023 19:24:03 +0100 Subject: [PATCH 1/4] Feature/support search by asset profile id (#2765) * Add support to search for an asset profile by id * Update changelog --- CHANGELOG.md | 4 ++++ apps/api/src/app/admin/admin.service.ts | 1 + 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6ddc7802b..717cf02a0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased +### Added + +- Added support to search for an asset profile by `id` as an administrator + ### Changed - Set the select column of the lazy-loaded activities table to stick at the end (experimental) diff --git a/apps/api/src/app/admin/admin.service.ts b/apps/api/src/app/admin/admin.service.ts index b46a0a13a..40aaf286e 100644 --- a/apps/api/src/app/admin/admin.service.ts +++ b/apps/api/src/app/admin/admin.service.ts @@ -176,6 +176,7 @@ export class AdminService { if (searchQuery) { where.OR = [ + { id: { mode: 'insensitive', startsWith: searchQuery } }, { isin: { mode: 'insensitive', startsWith: searchQuery } }, { name: { mode: 'insensitive', startsWith: searchQuery } }, { symbol: { mode: 'insensitive', startsWith: searchQuery } } From beb9e2c43f9612481cb057b09b047b49938d9519 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Thu, 21 Dec 2023 11:44:36 +0100 Subject: [PATCH 2/4] Feature/modernize nx executors (#2767) * Modernize Nx executors * @nx/eslint:lint * @nx/webpack:webpack * Update changelog --- CHANGELOG.md | 3 +++ apps/api/project.json | 4 ++-- apps/client/project.json | 2 +- apps/ui-e2e/project.json | 2 +- libs/common/project.json | 2 +- libs/ui/project.json | 2 +- 6 files changed, 9 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 717cf02a0..4fd49a7ab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Set the select column of the lazy-loaded activities table to stick at the end (experimental) - Improved the validation of the currency management in the admin control panel - Improved the performance of the value redaction interceptor for the impersonation mode by eliminating `cloneDeep` +- Modernized the `Nx` executors + - `@nx/eslint:lint` + - `@nx/webpack:webpack` ### Fixed diff --git a/apps/api/project.json b/apps/api/project.json index 81f887f41..f3c8bd1e0 100644 --- a/apps/api/project.json +++ b/apps/api/project.json @@ -7,7 +7,7 @@ "generators": {}, "targets": { "build": { - "executor": "@nrwl/webpack:webpack", + "executor": "@nx/webpack:webpack", "options": { "outputPath": "dist/apps/api", "main": "apps/api/src/main.ts", @@ -40,7 +40,7 @@ } }, "lint": { - "executor": "@nrwl/linter:eslint", + "executor": "@nx/eslint:lint", "options": { "lintFilePatterns": ["apps/api/**/*.ts"] } diff --git a/apps/client/project.json b/apps/client/project.json index 7563b3a75..26292ffee 100644 --- a/apps/client/project.json +++ b/apps/client/project.json @@ -207,7 +207,7 @@ } }, "lint": { - "executor": "@nrwl/linter:eslint", + "executor": "@nx/eslint:lint", "options": { "lintFilePatterns": ["apps/client/**/*.ts"] } diff --git a/apps/ui-e2e/project.json b/apps/ui-e2e/project.json index ab447db1b..4595b6c66 100644 --- a/apps/ui-e2e/project.json +++ b/apps/ui-e2e/project.json @@ -18,7 +18,7 @@ } }, "lint": { - "executor": "@nrwl/linter:eslint", + "executor": "@nx/eslint:lint", "options": { "lintFilePatterns": ["apps/ui-e2e/**/*.{js,ts}"] } diff --git a/libs/common/project.json b/libs/common/project.json index cee21720d..3bed072ff 100644 --- a/libs/common/project.json +++ b/libs/common/project.json @@ -5,7 +5,7 @@ "projectType": "library", "targets": { "lint": { - "executor": "@nrwl/linter:eslint", + "executor": "@nx/eslint:lint", "options": { "lintFilePatterns": ["libs/common/**/*.ts"] } diff --git a/libs/ui/project.json b/libs/ui/project.json index 8f7529974..58e959344 100644 --- a/libs/ui/project.json +++ b/libs/ui/project.json @@ -18,7 +18,7 @@ } }, "lint": { - "executor": "@nrwl/linter:eslint", + "executor": "@nx/eslint:lint", "options": { "lintFilePatterns": ["libs/ui/src/**/*.ts", "libs/ui/src/**/*.html"] } From 337ca328c32b69f74cf8ca7f323bdc38404c3e47 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Fri, 22 Dec 2023 20:16:02 +0100 Subject: [PATCH 3/4] Feature/drop activity id on import (#2769) * Drop activity id on import * Update changelog --- CHANGELOG.md | 1 + .../import-activities-dialog.component.ts | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4fd49a7ab..ada43f294 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Set the select column of the lazy-loaded activities table to stick at the end (experimental) +- Dropped the activity id in the activities import - Improved the validation of the currency management in the admin control panel - Improved the performance of the value redaction interceptor for the impersonation mode by eliminating `cloneDeep` - Modernized the `Nx` executors diff --git a/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts b/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts index fcc2decd8..7fc4b234b 100644 --- a/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts +++ b/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts @@ -260,6 +260,14 @@ export class ImportActivitiesDialog implements OnDestroy { } } + content.activities = content.activities.map((activity) => { + if (activity.id) { + delete activity.id; + } + + return activity; + }); + try { const { activities } = await this.importActivitiesService.importJson({ From f27e21f9a0d8930b1251568a735e12151695aabb Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sat, 23 Dec 2023 17:45:37 +0100 Subject: [PATCH 4/4] Extend issue template (#2776) --- .github/ISSUE_TEMPLATE/bug_report.md | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 0d93138f6..1fabe2f48 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -6,7 +6,13 @@ labels: '' assignees: '' --- -The Issue tracker is **ONLY** used for reporting bugs. New features should be discussed in our [Slack](https://join.slack.com/t/ghostfolio/shared_invite/zt-vsaan64h-F_I0fEo5M0P88lP9ibCxFg) community or in [Discussions](https://github.com/ghostfolio/ghostfolio/discussions). +**Important Notice** + +The issue tracker is **ONLY** used for reporting bugs. New features should be discussed in our [Slack](https://join.slack.com/t/ghostfolio/shared_invite/zt-vsaan64h-F_I0fEo5M0P88lP9ibCxFg) community or in [Discussions](https://github.com/ghostfolio/ghostfolio/discussions). + +Incomplete or non-reproducible issues may be closed, but we are here to help! If you encounter difficulties reproducing the bug or need assistance, please reach out to our community channels mentioned above. + +Thank you for your understanding and cooperation! **Bug Description** @@ -36,8 +42,9 @@ The Issue tracker is **ONLY** used for reporting bugs. New features should be di -- Cloud or Self-hosted - Ghostfolio Version X.Y.Z +- Cloud or Self-hosted +- Experimental Features enabled or disabled - Browser - OS