Task/allow editing country and sector data for all assets (#6284)

* Allow editing country and sector data for all assets

* Update changelog

CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+
+### Changed
+
+- Extended the asset profile details dialog in the admin control panel to support editing countries for all asset types
+- Extended the asset profile details dialog in the admin control panel to support editing sectors for all asset types
+
 ## 2.253.0 - 2026-03-06
 
 ### Added

apps/api/src/app/admin/admin.service.ts

@@ -625,23 +625,23 @@ export class AdminService {
       const symbolProfileOverrides = {
         assetClass: assetClass as AssetClass,
         assetSubClass: assetSubClass as AssetSubClass,
+        countries: countries as Prisma.JsonArray,
         name: name as string,
+        sectors: sectors as Prisma.JsonArray,
         url: url as string
       };
 
       const updatedSymbolProfile: Prisma.SymbolProfileUpdateInput = {
         comment,
-        countries,
         currency,
         dataSource,
         holdings,
         isActive,
         scraperConfiguration,
-        sectors,
         symbol,
         symbolMapping,
         ...(dataSource === 'MANUAL'
-          ? { assetClass, assetSubClass, name, url }
+          ? { assetClass, assetSubClass, countries, name, sectors, url }
           : {
               SymbolProfileOverrides: {
                 upsert: {

apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts

@@ -19,7 +19,7 @@ import {
   User
 } from '@ghostfolio/common/interfaces';
 import { DateRange } from '@ghostfolio/common/types';
-import { validateObjectForForm } from '@ghostfolio/common/utils';
+import { jsonValidator, validateObjectForForm } from '@ghostfolio/common/utils';
 import { GfCurrencySelectorComponent } from '@ghostfolio/ui/currency-selector';
 import { GfEntityLogoComponent } from '@ghostfolio/ui/entity-logo';
 import { GfHistoricalMarketDataEditorComponent } from '@ghostfolio/ui/historical-market-data-editor';
@@ -149,7 +149,7 @@ export class GfAssetProfileDialogComponent implements OnInit {
     assetClass: new FormControl<AssetClass>(undefined),
     assetSubClass: new FormControl<AssetSubClass>(undefined),
     comment: '',
-    countries: '',
+    countries: ['', jsonValidator()],
     currency: '',
     historicalData: this.formBuilder.group({
       csvString: ''
@@ -158,14 +158,14 @@ export class GfAssetProfileDialogComponent implements OnInit {
     name: ['', Validators.required],
     scraperConfiguration: this.formBuilder.group({
       defaultMarketPrice: null,
-      headers: JSON.stringify({}),
+      headers: [JSON.stringify({}), jsonValidator()],
       locale: '',
       mode: '',
       selector: '',
       url: ''
     }),
-    sectors: '',
+    sectors: ['', jsonValidator()],
-    symbolMapping: '',
+    symbolMapping: ['', jsonValidator()],
     url: ''
   });
 

apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html

@@ -393,30 +393,28 @@
                 ></textarea>
               </mat-form-field>
             </div>
-            @if (assetProfile?.dataSource === 'MANUAL') {
+            <div>
-              <div>
+              <mat-form-field appearance="outline" class="w-100">
-                <mat-form-field appearance="outline" class="w-100">
+                <mat-label i18n>Sectors</mat-label>
-                  <mat-label i18n>Sectors</mat-label>
+                <textarea
-                  <textarea
+                  cdkTextareaAutosize
-                    cdkTextareaAutosize
+                  formControlName="sectors"
-                    formControlName="sectors"
+                  matInput
-                    matInput
+                  type="text"
-                    type="text"
+                ></textarea>
-                  ></textarea>
+              </mat-form-field>
-                </mat-form-field>
+            </div>
-              </div>
+            <div>
-              <div>
+              <mat-form-field appearance="outline" class="w-100">
-                <mat-form-field appearance="outline" class="w-100">
+                <mat-label i18n>Countries</mat-label>
-                  <mat-label i18n>Countries</mat-label>
+                <textarea
-                  <textarea
+                  cdkTextareaAutosize
-                    cdkTextareaAutosize
+                  formControlName="countries"
-                    formControlName="countries"
+                  matInput
-                    matInput
+                  type="text"
-                    type="text"
+                ></textarea>
-                  ></textarea>
+              </mat-form-field>
-                </mat-form-field>
+            </div>
-              </div>
-            }
             <div>
               <mat-form-field appearance="outline" class="w-100 without-hint">
                 <mat-label i18n>Url</mat-label>

libs/common/src/lib/utils/form.util.ts

@@ -1,6 +1,17 @@
+import { AbstractControl, ValidationErrors, ValidatorFn } from '@angular/forms';
 import { FormGroup } from '@angular/forms';
 import { plainToInstance } from 'class-transformer';
-import { validate } from 'class-validator';
+import { isJSON, validate } from 'class-validator';
+
+export function jsonValidator(): ValidatorFn {
+  return (control: AbstractControl): ValidationErrors | null => {
+    if (!isJSON(control.value)) {
+      return { invalidJson: true };
+    }
+
+    return null;
+  };
+}
 
 export async function validateObjectForForm<T>({
   classDto,

libs/common/src/lib/utils/index.ts

@@ -1,3 +1,3 @@
-import { validateObjectForForm } from './form.util';
+import { jsonValidator, validateObjectForForm } from './form.util';
 
-export { validateObjectForForm };
+export { jsonValidator, validateObjectForForm };