Browse Source

Feature/hide average buy price in position detail chart if no holding (#2133)

* Hide the average buy price if no holding

* Update changelog
pull/2136/head
Thomas Kaul 1 year ago
committed by GitHub
parent
commit
c434b730a8
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 1
      CHANGELOG.md
  2. 9
      apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.component.ts
  3. 3
      libs/ui/src/lib/line-chart/line-chart.component.ts

1
CHANGELOG.md

@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Hid the average buy price in the position detail chart if there is no holding
- Improved the language localization for French (`fr`)
- Refactored the blog articles to standalone components

9
apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.component.ts

@ -215,6 +215,15 @@ export class PositionDetailDialog implements OnDestroy, OnInit {
this.benchmarkDataItems[0].value = this.averagePrice;
}
this.benchmarkDataItems = this.benchmarkDataItems.map(
({ date, value }) => {
return {
date,
value: value === 0 ? null : value
};
}
);
if (Number.isInteger(this.quantity)) {
this.quantityPrecision = 0;
} else if (this.SymbolProfile?.assetSubClass === 'CRYPTOCURRENCY') {

3
libs/ui/src/lib/line-chart/line-chart.component.ts

@ -154,7 +154,8 @@ export class LineChartComponent implements AfterViewInit, OnChanges, OnDestroy {
data: benchmarkPrices,
fill: false,
label: this.benchmarkLabel,
pointRadius: 0
pointRadius: 0,
spanGaps: false
},
{
backgroundColor: gradient,

Loading…
Cancel
Save