From c4816c809c48472bb1ea80dc0aeb1231ca3edf05 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sat, 24 Aug 2024 09:08:37 +0200
Subject: [PATCH] Improve caching

---
 apps/api/src/app/redis-cache/redis-cache.service.ts | 10 ++++++++--
 apps/api/src/app/user/user.controller.ts            |  7 ++-----
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/apps/api/src/app/redis-cache/redis-cache.service.ts b/apps/api/src/app/redis-cache/redis-cache.service.ts
index efe7ebd0a..341dc4acf 100644
--- a/apps/api/src/app/redis-cache/redis-cache.service.ts
+++ b/apps/api/src/app/redis-cache/redis-cache.service.ts
@@ -26,7 +26,13 @@ export class RedisCacheService {
   }
 
   public async getKeys(aPrefix?: string): Promise<string[]> {
-    return this.cache.store.keys(aPrefix);
+    let prefix = aPrefix;
+
+    if (prefix) {
+      prefix = `${prefix}*`;
+    }
+
+    return this.cache.store.keys(prefix);
   }
 
   public getPortfolioSnapshotKey({
@@ -67,7 +73,7 @@ export class RedisCacheService {
     );
 
     for (const key of keys) {
-      this.remove(key);
+      await this.remove(key);
     }
   }
 
diff --git a/apps/api/src/app/user/user.controller.ts b/apps/api/src/app/user/user.controller.ts
index 57f09da24..c23870437 100644
--- a/apps/api/src/app/user/user.controller.ts
+++ b/apps/api/src/app/user/user.controller.ts
@@ -144,10 +144,7 @@ export class UserController {
       );
     }
 
-    const haveFiltersChanged =
-      'filters.accounts' in data ||
-      'filters.assetClasses' in data ||
-      'filters.tags' in data;
+    const emitPortfolioChangedEvent = 'baseCurrency' in data;
 
     const userSettings: UserSettings = merge(
       {},
@@ -162,8 +159,8 @@ export class UserController {
     }
 
     return this.userService.updateUserSetting({
+      emitPortfolioChangedEvent,
       userSettings,
-      emitPortfolioChangedEvent: haveFiltersChanged,
       userId: this.request.user.id
     });
   }