Merge remote-tracking branch 'upstream/main' into fix/activities_table_format

CHANGELOG.md

@@ -5,7 +5,18 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## Unreleased
+## 2.203.0 - 2025-09-27
+
+### Added
+
+- Added support for column sorting to the queue jobs table in the admin control panel
+- Added a blog post: _Hacktoberfest 2025_
+
+### Changed
+
+- Removed the deprecated `ITEM` activity type
+
+## 2.202.0 - 2025-09-26
 
 ### Added
 
@@ -14,10 +25,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - Extended the tags selector component to support form control
+- Changed the deprecated `ITEM` activity type to `VALUABLE` in the create or update activity dialog
 
 ### Fixed
 
 - Fixed an issue where the save button was not enabled after editing tags in the create or update activity dialog
+- Fixed an issue in the investment calculation when selling all units of a holding
 
 ## 2.201.0 - 2025-09-24
 

apps/api/src/app/endpoints/sitemap/sitemap.controller.ts

@@ -37,6 +37,7 @@ export class SitemapController {
     response.setHeader('content-type', 'application/xml');
     response.send(
       interpolate(this.sitemapXml, {
+        blogPosts: this.sitemapService.getBlogPosts({ currentDate }),
         personalFinanceTools: this.configurationService.get(
           'ENABLE_FEATURE_SUBSCRIPTION'
         )

apps/api/src/app/endpoints/sitemap/sitemap.service.ts

@@ -17,6 +17,121 @@ export class SitemapService {
     private readonly i18nService: I18nService
   ) {}
 
+  public getBlogPosts({ currentDate }: { currentDate: string }) {
+    const rootUrl = this.configurationService.get('ROOT_URL');
+
+    return [
+      {
+        languageCode: 'de',
+        routerLink: ['2021', '07', 'hallo-ghostfolio']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2021', '07', 'hello-ghostfolio']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2022', '01', 'ghostfolio-first-months-in-open-source']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2022', '07', 'ghostfolio-meets-internet-identity']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2022', '07', 'how-do-i-get-my-finances-in-order']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2022', '08', '500-stars-on-github']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2022', '10', 'hacktoberfest-2022']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2022', '11', 'black-friday-2022']
+      },
+      {
+        languageCode: 'en',
+        routerLink: [
+          '2022',
+          '12',
+          'the-importance-of-tracking-your-personal-finances'
+        ]
+      },
+      {
+        languageCode: 'de',
+        routerLink: ['2023', '01', 'ghostfolio-auf-sackgeld-vorgestellt']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2023', '02', 'ghostfolio-meets-umbrel']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2023', '03', 'ghostfolio-reaches-1000-stars-on-github']
+      },
+      {
+        languageCode: 'en',
+        routerLink: [
+          '2023',
+          '05',
+          'unlock-your-financial-potential-with-ghostfolio'
+        ]
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2023', '07', 'exploring-the-path-to-fire']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2023', '08', 'ghostfolio-joins-oss-friends']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2023', '09', 'ghostfolio-2']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2023', '09', 'hacktoberfest-2023']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2023', '11', 'black-week-2023']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2023', '11', 'hacktoberfest-2023-debriefing']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2024', '09', 'hacktoberfest-2024']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2024', '11', 'black-weeks-2024']
+      },
+      {
+        languageCode: 'en',
+        routerLink: ['2025', '09', 'hacktoberfest-2025']
+      }
+    ]
+      .map(({ languageCode, routerLink }) => {
+        return this.createRouteSitemapUrl({
+          currentDate,
+          languageCode,
+          rootUrl,
+          route: {
+            routerLink: [publicRoutes.blog.path, ...routerLink],
+            path: undefined
+          }
+        });
+      })
+      .join('\n');
+  }
+
   public getPersonalFinanceTools({ currentDate }: { currentDate: string }) {
     const rootUrl = this.configurationService.get('ROOT_URL');
 
@@ -43,20 +158,21 @@ export class SitemapService {
       });
 
       return personalFinanceTools.map(({ alias, key }) => {
-        const location = [
+        const routerLink = [
-          rootUrl,
-          languageCode,
           resourcesPath,
           personalFinanceToolsPath,
           `${productPath}-${alias ?? key}`
-        ].join('/');
+        ];
-
+
-        return [
+        return this.createRouteSitemapUrl({
-          '  <url>',
+          currentDate,
-          `    <loc>${location}</loc>`,
+          languageCode,
-          `    <lastmod>${currentDate}T00:00:00+00:00</lastmod>`,
+          rootUrl,
-          '  </url>'
+          route: {
-        ].join('\n');
+            routerLink,
+            path: undefined
+          }
+        });
       });
     }).join('\n');
   }

apps/api/src/app/import/import.service.ts

@@ -718,12 +718,6 @@ export class ImportService {
       index,
       { currency, dataSource, symbol, type }
     ] of activitiesDto.entries()) {
-      if (type === 'ITEM') {
-        throw new Error(
-          `activities.${index}.type ("${type}") is deprecated, please use "BUY" instead`
-        );
-      }
-
       if (!dataSources.includes(dataSource)) {
         throw new Error(
           `activities.${index}.dataSource ("${dataSource}") is not valid`

apps/api/src/app/portfolio/calculator/portfolio-calculator.ts

@@ -922,7 +922,7 @@ export abstract class PortfolioCalculator {
       if (oldAccumulatedSymbol) {
         let investment = oldAccumulatedSymbol.investment;
 
-        const newQuantity = quantity
+        let newQuantity = quantity
           .mul(factor)
           .plus(oldAccumulatedSymbol.quantity);
 
@@ -948,6 +948,12 @@ export abstract class PortfolioCalculator {
           }
         }
 
+        if (newQuantity.abs().lt(Number.EPSILON)) {
+          // Reset to zero if quantity is (almost) zero to avoid rounding issues
+          investment = new Big(0);
+          newQuantity = new Big(0);
+        }
+
         currentTransactionPointItem = {
           currency,
           dataSource,

apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-msft-buy-and-sell.spec.ts

@@ -0,0 +1,146 @@
+import { Activity } from '@ghostfolio/api/app/order/interfaces/activities.interface';
+import {
+  activityDummyData,
+  symbolProfileDummyData,
+  userDummyData
+} from '@ghostfolio/api/app/portfolio/calculator/portfolio-calculator-test-utils';
+import { PortfolioCalculatorFactory } from '@ghostfolio/api/app/portfolio/calculator/portfolio-calculator.factory';
+import { CurrentRateService } from '@ghostfolio/api/app/portfolio/current-rate.service';
+import { CurrentRateServiceMock } from '@ghostfolio/api/app/portfolio/current-rate.service.mock';
+import { RedisCacheService } from '@ghostfolio/api/app/redis-cache/redis-cache.service';
+import { RedisCacheServiceMock } from '@ghostfolio/api/app/redis-cache/redis-cache.service.mock';
+import { ConfigurationService } from '@ghostfolio/api/services/configuration/configuration.service';
+import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data/exchange-rate-data.service';
+import { PortfolioSnapshotService } from '@ghostfolio/api/services/queues/portfolio-snapshot/portfolio-snapshot.service';
+import { PortfolioSnapshotServiceMock } from '@ghostfolio/api/services/queues/portfolio-snapshot/portfolio-snapshot.service.mock';
+import { parseDate } from '@ghostfolio/common/helper';
+import { PerformanceCalculationType } from '@ghostfolio/common/types/performance-calculation-type.type';
+
+jest.mock('@ghostfolio/api/app/portfolio/current-rate.service', () => {
+  return {
+    CurrentRateService: jest.fn().mockImplementation(() => {
+      return CurrentRateServiceMock;
+    })
+  };
+});
+
+jest.mock(
+  '@ghostfolio/api/services/queues/portfolio-snapshot/portfolio-snapshot.service',
+  () => {
+    return {
+      // eslint-disable-next-line @typescript-eslint/naming-convention
+      PortfolioSnapshotService: jest.fn().mockImplementation(() => {
+        return PortfolioSnapshotServiceMock;
+      })
+    };
+  }
+);
+
+jest.mock('@ghostfolio/api/app/redis-cache/redis-cache.service', () => {
+  return {
+    // eslint-disable-next-line @typescript-eslint/naming-convention
+    RedisCacheService: jest.fn().mockImplementation(() => {
+      return RedisCacheServiceMock;
+    })
+  };
+});
+
+describe('PortfolioCalculator', () => {
+  let configurationService: ConfigurationService;
+  let currentRateService: CurrentRateService;
+  let exchangeRateDataService: ExchangeRateDataService;
+  let portfolioCalculatorFactory: PortfolioCalculatorFactory;
+  let portfolioSnapshotService: PortfolioSnapshotService;
+  let redisCacheService: RedisCacheService;
+
+  beforeEach(() => {
+    configurationService = new ConfigurationService();
+    currentRateService = new CurrentRateService(null, null, null, null);
+    exchangeRateDataService = new ExchangeRateDataService(
+      null,
+      null,
+      null,
+      null
+    );
+    portfolioSnapshotService = new PortfolioSnapshotService(null);
+    redisCacheService = new RedisCacheService(null, null);
+    portfolioCalculatorFactory = new PortfolioCalculatorFactory(
+      configurationService,
+      currentRateService,
+      exchangeRateDataService,
+      portfolioSnapshotService,
+      redisCacheService
+    );
+  });
+
+  describe('get transaction point', () => {
+    it('with MSFT buy and sell with fractional quantities (multiples of 1/3)', () => {
+      jest.useFakeTimers().setSystemTime(parseDate('2024-04-01').getTime());
+
+      const activities: Activity[] = [
+        {
+          ...activityDummyData,
+          date: new Date('2024-03-08'),
+          feeInAssetProfileCurrency: 0,
+          quantity: 0.3333333333333333,
+          SymbolProfile: {
+            ...symbolProfileDummyData,
+            currency: 'USD',
+            dataSource: 'YAHOO',
+            name: 'Microsoft Inc.',
+            symbol: 'MSFT'
+          },
+          type: 'BUY',
+          unitPriceInAssetProfileCurrency: 408
+        },
+        {
+          ...activityDummyData,
+          date: new Date('2024-03-13'),
+          quantity: 0.6666666666666666,
+          feeInAssetProfileCurrency: 0,
+          SymbolProfile: {
+            ...symbolProfileDummyData,
+            currency: 'USD',
+            dataSource: 'YAHOO',
+            name: 'Microsoft Inc.',
+            symbol: 'MSFT'
+          },
+          type: 'BUY',
+          unitPriceInAssetProfileCurrency: 400
+        },
+        {
+          ...activityDummyData,
+          date: new Date('2024-03-14'),
+          quantity: 1,
+          feeInAssetProfileCurrency: 0,
+          SymbolProfile: {
+            ...symbolProfileDummyData,
+            currency: 'USD',
+            dataSource: 'YAHOO',
+            name: 'Microsoft Inc.',
+            symbol: 'MSFT'
+          },
+          type: 'SELL',
+          unitPriceInAssetProfileCurrency: 411
+        }
+      ];
+
+      const portfolioCalculator = portfolioCalculatorFactory.createCalculator({
+        activities,
+        calculationType: PerformanceCalculationType.ROAI,
+        currency: 'USD',
+        userId: userDummyData.id
+      });
+
+      const transactionPoints = portfolioCalculator.getTransactionPoints();
+      const lastTransactionPoint =
+        transactionPoints[transactionPoints.length - 1];
+      const position = lastTransactionPoint.items.find(
+        (item) => item.symbol === 'MSFT'
+      );
+
+      expect(position.investment.toNumber()).toBe(0);
+      expect(position.quantity.toNumber()).toBe(0);
+    });
+  });
+});

apps/api/src/assets/sitemap.xml

@@ -5,5 +5,6 @@
   xsi:schemaLocation="http://www.sitemaps.org/schemas/sitemap/0.9
     http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd">
   ${publicRoutes}
+  ${blogPosts}
   ${personalFinanceTools}
 </urlset>

apps/api/src/middlewares/html-template.middleware.ts

@@ -75,6 +75,10 @@ const locales = {
   '/en/blog/2024/11/black-weeks-2024': {
     featureGraphicPath: 'assets/images/blog/black-weeks-2024.jpg',
     title: `Black Weeks 2024 - ${title}`
+  },
+  '/en/blog/2025/09/hacktoberfest-2025': {
+    featureGraphicPath: 'assets/images/blog/hacktoberfest-2025.png',
+    title: `Hacktoberfest 2025 - ${title}`
   }
 };
 

apps/client/src/app/components/admin-jobs/admin-jobs.component.ts

@@ -16,7 +16,8 @@ import {
   ChangeDetectorRef,
   Component,
   OnDestroy,
-  OnInit
+  OnInit,
+  ViewChild
 } from '@angular/core';
 import {
   FormBuilder,
@@ -27,6 +28,7 @@ import {
 import { MatButtonModule } from '@angular/material/button';
 import { MatMenuModule } from '@angular/material/menu';
 import { MatSelectModule } from '@angular/material/select';
+import { MatSort, MatSortModule } from '@angular/material/sort';
 import { MatTableDataSource, MatTableModule } from '@angular/material/table';
 import { IonIcon } from '@ionic/angular/standalone';
 import { JobStatus } from 'bull';
@@ -44,6 +46,7 @@ import {
   removeCircleOutline,
   timeOutline
 } from 'ionicons/icons';
+import { get } from 'lodash';
 import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
 import { Subject } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';
@@ -57,6 +60,7 @@ import { takeUntil } from 'rxjs/operators';
     MatButtonModule,
     MatMenuModule,
     MatSelectModule,
+    MatSortModule,
     MatTableModule,
     NgxSkeletonLoaderModule,
     ReactiveFormsModule
@@ -66,6 +70,8 @@ import { takeUntil } from 'rxjs/operators';
   templateUrl: './admin-jobs.html'
 })
 export class GfAdminJobsComponent implements OnDestroy, OnInit {
+  @ViewChild(MatSort) sort: MatSort;
+
   public DATA_GATHERING_QUEUE_PRIORITY_LOW = DATA_GATHERING_QUEUE_PRIORITY_LOW;
   public DATA_GATHERING_QUEUE_PRIORITY_HIGH =
     DATA_GATHERING_QUEUE_PRIORITY_HIGH;
@@ -196,6 +202,8 @@ export class GfAdminJobsComponent implements OnDestroy, OnInit {
       .pipe(takeUntil(this.unsubscribeSubject))
       .subscribe(({ jobs }) => {
         this.dataSource = new MatTableDataSource(jobs);
+        this.dataSource.sort = this.sort;
+        this.dataSource.sortingDataAccessor = get;
 
         this.isLoading = false;
 

apps/client/src/app/components/admin-jobs/admin-jobs.html

@@ -16,9 +16,21 @@
           </mat-select>
         </mat-form-field>
       </form>
-      <table class="gf-table w-100" mat-table [dataSource]="dataSource">
+      <table
+        class="gf-table w-100"
+        mat-table
+        matSort
+        matSortActive="created"
+        matSortDirection="desc"
+        [dataSource]="dataSource"
+      >
         <ng-container matColumnDef="index">
-          <th *matHeaderCellDef class="px-1 py-2 text-right" mat-header-cell>
+          <th
+            *matHeaderCellDef
+            class="px-1 py-2 text-right"
+            mat-header-cell
+            mat-sort-header="id"
+          >
             <ng-container i18n>Job ID</ng-container>
           </th>
           <td *matCellDef="let element" class="px-1 py-2 text-right" mat-cell>
@@ -27,7 +39,12 @@
         </ng-container>
 
         <ng-container matColumnDef="type">
-          <th *matHeaderCellDef class="px-1 py-2" mat-header-cell>
+          <th
+            *matHeaderCellDef
+            class="px-1 py-2"
+            mat-header-cell
+            mat-sort-header="name"
+          >
             <ng-container i18n>Type</ng-container>
           </th>
           <td *matCellDef="let element" class="px-1 py-2" mat-cell>
@@ -42,7 +59,12 @@
         </ng-container>
 
         <ng-container matColumnDef="symbol">
-          <th *matHeaderCellDef class="px-1 py-2" mat-header-cell>
+          <th
+            *matHeaderCellDef
+            class="px-1 py-2"
+            mat-header-cell
+            mat-sort-header="data.symbol"
+          >
             <ng-container i18n>Symbol</ng-container>
           </th>
           <td *matCellDef="let element" class="px-1 py-2" mat-cell>
@@ -51,7 +73,12 @@
         </ng-container>
 
         <ng-container matColumnDef="dataSource">
-          <th *matHeaderCellDef class="px-1 py-2" mat-header-cell>
+          <th
+            *matHeaderCellDef
+            class="px-1 py-2"
+            mat-header-cell
+            mat-sort-header="data.dataSource"
+          >
             <ng-container i18n>Data Source</ng-container>
           </th>
           <td *matCellDef="let element" class="px-1 py-2" mat-cell>
@@ -60,7 +87,12 @@
         </ng-container>
 
         <ng-container matColumnDef="priority">
-          <th *matHeaderCellDef class="px-1 py-2" mat-header-cell>
+          <th
+            *matHeaderCellDef
+            class="px-1 py-2"
+            mat-header-cell
+            mat-sort-header="opts.priority"
+          >
             <ng-container i18n>Priority</ng-container>
           </th>
           <td *matCellDef="let element" class="px-1 py-2" mat-cell>
@@ -79,7 +111,12 @@
         </ng-container>
 
         <ng-container matColumnDef="attempts">
-          <th *matHeaderCellDef class="px-1 py-2 text-right" mat-header-cell>
+          <th
+            *matHeaderCellDef
+            class="px-1 py-2 text-right"
+            mat-header-cell
+            mat-sort-header="attemptsMade"
+          >
             <ng-container i18n>Attempts</ng-container>
           </th>
           <td *matCellDef="let element" class="px-1 py-2 text-right" mat-cell>
@@ -88,7 +125,12 @@
         </ng-container>
 
         <ng-container matColumnDef="created">
-          <th *matHeaderCellDef class="px-1 py-2" mat-header-cell>
+          <th
+            *matHeaderCellDef
+            class="px-1 py-2"
+            mat-header-cell
+            mat-sort-header="timestamp"
+          >
             <ng-container i18n>Created</ng-container>
           </th>
           <td *matCellDef="let element" class="px-1 py-2" mat-cell>

apps/client/src/app/pages/blog/2025/09/hacktoberfest-2025/hacktoberfest-2025-page.component.ts

@@ -0,0 +1,17 @@
+import { publicRoutes } from '@ghostfolio/common/routes/routes';
+
+import { Component } from '@angular/core';
+import { MatButtonModule } from '@angular/material/button';
+import { RouterModule } from '@angular/router';
+
+@Component({
+  host: { class: 'page' },
+  imports: [MatButtonModule, RouterModule],
+  selector: 'gf-hacktoberfest-2025-page',
+  templateUrl: './hacktoberfest-2025-page.html'
+})
+export class Hacktoberfest2025PageComponent {
+  public routerLinkAbout = publicRoutes.about.routerLink;
+  public routerLinkBlog = publicRoutes.blog.routerLink;
+  public routerLinkOpenStartup = publicRoutes.openStartup.routerLink;
+}

apps/client/src/app/pages/blog/2025/09/hacktoberfest-2025/hacktoberfest-2025-page.html

@@ -0,0 +1,201 @@
+<div class="blog container">
+  <div class="row">
+    <div class="col-md-8 offset-md-2">
+      <article>
+        <div class="mb-4 text-center">
+          <h1 class="mb-1">Hacktoberfest 2025</h1>
+          <div class="mb-3 text-muted"><small>2025-09-27</small></div>
+          <img
+            alt="Hacktoberfest 2025 with Ghostfolio Teaser"
+            class="rounded w-100"
+            src="../assets/images/blog/hacktoberfest-2025.png"
+            title="Hacktoberfest 2025 with Ghostfolio"
+          />
+        </div>
+        <section class="mb-4">
+          <p>
+            Ghostfolio is joining
+            <a href="https://hacktoberfest.com">Hacktoberfest</a> for the fourth
+            time and <a [routerLink]="routerLinkAbout">we</a> are looking
+            forward to meeting new open-source contributors along the way. Every
+            year in October, Hacktoberfest celebrates open source by
+            highlighting projects, maintainers, and contributors from around the
+            globe. Open source maintainers dedicate extra time to support new
+            contributors while guiding them through their first pull requests on
+            <a href="https://github.com/ghostfolio/ghostfolio">GitHub</a>.
+          </p>
+        </section>
+        <section class="mb-4">
+          <h2 class="h4">
+            Meet Ghostfolio: a modern Dashboard for Personal Finance
+          </h2>
+          <p>
+            <a href="https://ghostfol.io">Ghostfolio</a> is a web application
+            that makes it easy to manage your personal finances. It aggregates
+            your assets and helps you make informed decisions to balance your
+            portfolio or plan future investments.
+          </p>
+          <p>
+            The software is fully written in
+            <a href="https://www.typescriptlang.org">TypeScript</a> and
+            organized as an <a href="https://nx.dev">Nx</a> workspace, utilizing
+            the latest framework releases. The backend is based on
+            <a href="https://nestjs.com">NestJS</a> in combination with
+            <a href="https://www.postgresql.org">PostgreSQL</a> as a database
+            together with <a href="https://www.prisma.io">Prisma</a> and
+            <a href="https://redis.io">Redis</a> for caching. The frontend is
+            developed with <a href="https://angular.dev">Angular</a>.
+          </p>
+          <p>
+            With over 200 contributors, the OSS project is used daily by a
+            growing global community. Ghostfolio counts more than
+            <a [routerLink]="routerLinkOpenStartup">6’500 stars on GitHub</a>
+            and
+            <a [routerLink]="routerLinkOpenStartup"
+              >1’600’000+ pulls on Docker Hub</a
+            >, standing out for its simple and user-friendly experience.
+          </p>
+        </section>
+        <section class="mb-4">
+          <h2 class="h4">How you can make an impact</h2>
+          <p>
+            Every contribution makes a difference. Whether it is implementing
+            new features, resolving bugs, refactoring code, enhancing
+            documentation, adding unit tests, or translating content into
+            another language, you can actively shape our project.
+          </p>
+          <p>
+            New to our codebase? No worries! We have labeled a few
+            <a
+              href="https://github.com/ghostfolio/ghostfolio/issues?q=is%3Aissue+is%3Aopen+label%3Ahacktoberfest"
+              >issues</a
+            >
+            with <code>hacktoberfest</code> that are ideal for newcomers.
+          </p>
+          <p>
+            The official Hacktoberfest website provides some valuable
+            <a
+              href="https://hacktoberfest.com/participation/#beginner-resources"
+              >resources for beginners</a
+            >
+            to start contributing in open source.
+          </p>
+        </section>
+        <section class="mb-4">
+          <h2 class="h4">Connect with us</h2>
+          <p>
+            If you have further questions or ideas, please join our
+            <a
+              href="https://join.slack.com/t/ghostfolio/shared_invite/zt-vsaan64h-F_I0fEo5M0P88lP9ibCxFg"
+              >Slack</a
+            >
+            community or get in touch on X
+            <a href="https://x.com/ghostfolio_">&#64;ghostfolio_</a>.
+          </p>
+          <p>
+            We look forward to collaborating.<br />
+            Thomas from Ghostfolio
+          </p>
+        </section>
+        <section class="mb-4">
+          <ul class="list-inline">
+            <li class="list-inline-item">
+              <span class="badge badge-light">Angular</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Community</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Dashboard</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Docker</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Finance</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Fintech</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Ghostfolio</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">GitHub</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Hacktoberfest</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Hacktoberfest 2025</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Investment</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">NestJS</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Nx</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">October</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Open Source</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">OSS</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Personal Finance</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Portfolio</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Portfolio Tracker</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Prisma</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Redis</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Software</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">TypeScript</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">UX</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Wealth</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Wealth Management</span>
+            </li>
+            <li class="list-inline-item">
+              <span class="badge badge-light">Web Application</span>
+            </li>
+          </ul>
+        </section>
+        <nav aria-label="breadcrumb">
+          <ol class="breadcrumb">
+            <li class="breadcrumb-item">
+              <a i18n [routerLink]="routerLinkBlog">Blog</a>
+            </li>
+            <li
+              aria-current="page"
+              class="active breadcrumb-item text-truncate"
+            >
+              Hacktoberfest 2025
+            </li>
+          </ol>
+        </nav>
+      </article>
+    </div>
+  </div>
+</div>

apps/client/src/app/pages/blog/blog-page-routing.module.ts

@@ -201,6 +201,15 @@ const routes: Routes = [
         (c) => c.BlackWeeks2024PageComponent
       ),
     title: 'Black Weeks 2024'
+  },
+  {
+    canActivate: [AuthGuard],
+    path: '2025/09/hacktoberfest-2025',
+    loadComponent: () =>
+      import(
+        './2025/09/hacktoberfest-2025/hacktoberfest-2025-page.component'
+      ).then((c) => c.Hacktoberfest2025PageComponent),
+    title: 'Hacktoberfest 2025'
   }
 ];
 

apps/client/src/app/pages/blog/blog-page.html

@@ -8,6 +8,30 @@
           finance</small
         >
       </h1>
+      <mat-card appearance="outlined" class="mb-3">
+        <mat-card-content class="p-0">
+          <div class="container p-0">
+            <div class="flex-nowrap no-gutters row">
+              <a
+                class="d-flex overflow-hidden p-3 w-100"
+                href="../en/blog/2025/09/hacktoberfest-2025"
+              >
+                <div class="flex-grow-1 overflow-hidden">
+                  <div class="h6 m-0 text-truncate">Hacktoberfest 2025</div>
+                  <div class="d-flex text-muted">2025-09-27</div>
+                </div>
+                <div class="align-items-center d-flex">
+                  <ion-icon
+                    class="chevron text-muted"
+                    name="chevron-forward-outline"
+                    size="small"
+                  />
+                </div>
+              </a>
+            </div>
+          </div>
+        </mat-card-content>
+      </mat-card>
       @if (hasPermissionForSubscription) {
         <mat-card appearance="outlined" class="mb-3">
           <mat-card-content class="p-0">

apps/client/src/app/pages/portfolio/activities/activities-page.component.ts

@@ -305,10 +305,10 @@ export class GfActivitiesPageComponent implements OnDestroy, OnInit {
     });
   }
 
-  public openUpdateActivityDialog(activity: Activity) {
+  public openUpdateActivityDialog(aActivity: Activity) {
     const dialogRef = this.dialog.open(GfCreateOrUpdateActivityDialog, {
       data: {
-        activity,
+        activity: aActivity,
         accounts: this.user?.accounts,
         user: this.user
       },
@@ -319,10 +319,10 @@ export class GfActivitiesPageComponent implements OnDestroy, OnInit {
     dialogRef
       .afterClosed()
       .pipe(takeUntil(this.unsubscribeSubject))
-      .subscribe((transaction: UpdateOrderDto | null) => {
+      .subscribe((activity: UpdateOrderDto) => {
-        if (transaction) {
+        if (activity) {
           this.dataService
-            .putOrder(transaction)
+            .putOrder(activity)
             .pipe(takeUntil(this.unsubscribeSubject))
             .subscribe({
               next: () => {

apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts

@@ -51,6 +51,7 @@ import { catchError, delay, takeUntil } from 'rxjs/operators';
 import { DataService } from '../../../../services/data.service';
 import { validateObjectForForm } from '../../../../util/form.util';
 import { CreateOrUpdateActivityDialogParams } from './interfaces/interfaces';
+import { ActivityType } from './types/activity-type.type';
 
 @Component({
   changeDetection: ChangeDetectionStrategy.OnPush,
@@ -178,9 +179,11 @@ export class GfCreateOrUpdateActivityDialog implements OnDestroy {
         };
       }) ?? [];
 
-    Object.keys(Type).forEach((type) => {
+    for (const type of Object.keys(ActivityType)) {
-      this.typesTranslationMap[Type[type]] = translate(Type[type]);
+      this.typesTranslationMap[ActivityType[type]] = translate(
-    });
+        ActivityType[type]
+      );
+    }
 
     this.activityForm = this.formBuilder.group({
       accountId: [
@@ -242,7 +245,9 @@ export class GfCreateOrUpdateActivityDialog implements OnDestroy {
       )
       .subscribe(async () => {
         if (
-          ['BUY', 'FEE', 'ITEM'].includes(this.activityForm.get('type').value)
+          ['BUY', 'FEE', 'VALUABLE'].includes(
+            this.activityForm.get('type').value
+          )
         ) {
           this.total =
             this.activityForm.get('quantity').value *
@@ -261,7 +266,7 @@ export class GfCreateOrUpdateActivityDialog implements OnDestroy {
     this.activityForm.get('accountId').valueChanges.subscribe((accountId) => {
       const type = this.activityForm.get('type').value;
 
-      if (['FEE', 'INTEREST', 'ITEM', 'LIABILITY'].includes(type)) {
+      if (['FEE', 'INTEREST', 'LIABILITY', 'VALUABLE'].includes(type)) {
         const currency =
           this.data.accounts.find(({ id }) => {
             return id === accountId;
@@ -357,9 +362,9 @@ export class GfCreateOrUpdateActivityDialog implements OnDestroy {
     this.activityForm
       .get('type')
       .valueChanges.pipe(takeUntil(this.unsubscribeSubject))
-      .subscribe((type: Type) => {
+      .subscribe((type: ActivityType) => {
         if (
-          type === 'ITEM' ||
+          type === 'VALUABLE' ||
           (this.activityForm.get('dataSource').value === 'MANUAL' &&
             type === 'BUY')
         ) {
@@ -384,7 +389,7 @@ export class GfCreateOrUpdateActivityDialog implements OnDestroy {
           this.activityForm.get('name').setValidators(Validators.required);
           this.activityForm.get('name').updateValueAndValidity();
 
-          if (type === 'ITEM') {
+          if (type === 'VALUABLE') {
             this.activityForm.get('quantity').setValue(1);
           }
 
@@ -513,11 +518,14 @@ export class GfCreateOrUpdateActivityDialog implements OnDestroy {
       currency: this.activityForm.get('currency').value,
       customCurrency: this.activityForm.get('currencyOfUnitPrice').value,
       date: this.activityForm.get('date').value,
-      dataSource: this.activityForm.get('dataSource').value,
+      dataSource:
+        this.activityForm.get('type').value === 'VALUABLE'
+          ? 'MANUAL'
+          : this.activityForm.get('dataSource').value,
       fee: this.activityForm.get('fee').value,
       quantity: this.activityForm.get('quantity').value,
       symbol:
-        (['FEE', 'INTEREST', 'ITEM', 'LIABILITY'].includes(
+        (['FEE', 'INTEREST', 'LIABILITY', 'VALUABLE'].includes(
           this.activityForm.get('type').value
         )
           ? undefined
@@ -526,7 +534,10 @@ export class GfCreateOrUpdateActivityDialog implements OnDestroy {
       tags: this.activityForm.get('tags').value?.map(({ id }) => {
         return id;
       }),
-      type: this.activityForm.get('type').value,
+      type:
+        this.activityForm.get('type').value === 'VALUABLE'
+          ? 'BUY'
+          : this.activityForm.get('type').value,
       unitPrice: this.activityForm.get('unitPrice').value
     };
 
@@ -543,12 +554,6 @@ export class GfCreateOrUpdateActivityDialog implements OnDestroy {
           object: activity
         });
 
-        if (activity.type === 'ITEM') {
-          // Transform deprecated type ITEM
-          activity.dataSource = 'MANUAL';
-          activity.type = 'BUY';
-        }
-
         this.dialogRef.close(activity);
       } else {
         (activity as UpdateOrderDto).id = this.data.activity?.id;
@@ -560,12 +565,6 @@ export class GfCreateOrUpdateActivityDialog implements OnDestroy {
           object: activity as UpdateOrderDto
         });
 
-        if (activity.type === 'ITEM') {
-          // Transform deprecated type ITEM
-          activity.dataSource = 'MANUAL';
-          activity.type = 'BUY';
-        }
-
         this.dialogRef.close(activity as UpdateOrderDto);
       }
     } catch (error) {

apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.html

@@ -65,9 +65,9 @@
               >Stocks, ETFs, bonds, cryptocurrencies, commodities</small
             >
           </mat-option>
-          <mat-option value="ITEM">
+          <mat-option value="VALUABLE">
             <span
-              ><b>{{ typesTranslationMap['ITEM'] }}</b></span
+              ><b>{{ typesTranslationMap['VALUABLE'] }}</b></span
             >
             <small class="d-block line-height-1 text-muted text-nowrap" i18n
               >Luxury items, real estate, private companies</small

apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/types/activity-type.type.ts

@@ -0,0 +1,8 @@
+import { Type } from '@prisma/client';
+
+export const ActivityType = {
+  ...Type,
+  VALUABLE: 'VALUABLE'
+} as const;
+
+export type ActivityType = (typeof ActivityType)[keyof typeof ActivityType];

apps/client/src/app/services/data.service.ts

@@ -512,48 +512,6 @@ export class DataService {
     );
   }
 
-  public fetchSymbolItem({
-    dataSource,
-    includeHistoricalData,
-    symbol
-  }: {
-    dataSource: DataSource | string;
-    includeHistoricalData?: number;
-    symbol: string;
-  }) {
-    let params = new HttpParams();
-
-    if (includeHistoricalData) {
-      params = params.append('includeHistoricalData', includeHistoricalData);
-    }
-
-    return this.http.get<SymbolItem>(`/api/v1/symbol/${dataSource}/${symbol}`, {
-      params
-    });
-  }
-
-  public fetchSymbols({
-    includeIndices = false,
-    query
-  }: {
-    includeIndices?: boolean;
-    query: string;
-  }) {
-    let params = new HttpParams().set('query', query);
-
-    if (includeIndices) {
-      params = params.append('includeIndices', includeIndices);
-    }
-
-    return this.http
-      .get<LookupResponse>('/api/v1/symbol/lookup', { params })
-      .pipe(
-        map(({ items }) => {
-          return items;
-        })
-      );
-  }
-
   public fetchPortfolioDetails({
     filters,
     withMarkets = false
@@ -725,6 +683,48 @@ export class DataService {
       );
   }
 
+  public fetchSymbolItem({
+    dataSource,
+    includeHistoricalData,
+    symbol
+  }: {
+    dataSource: DataSource | string;
+    includeHistoricalData?: number;
+    symbol: string;
+  }) {
+    let params = new HttpParams();
+
+    if (includeHistoricalData) {
+      params = params.append('includeHistoricalData', includeHistoricalData);
+    }
+
+    return this.http.get<SymbolItem>(`/api/v1/symbol/${dataSource}/${symbol}`, {
+      params
+    });
+  }
+
+  public fetchSymbols({
+    includeIndices = false,
+    query
+  }: {
+    includeIndices?: boolean;
+    query: string;
+  }) {
+    let params = new HttpParams().set('query', query);
+
+    if (includeIndices) {
+      params = params.append('includeIndices', includeIndices);
+    }
+
+    return this.http
+      .get<LookupResponse>('/api/v1/symbol/lookup', { params })
+      .pipe(
+        map(({ items }) => {
+          return items;
+        })
+      );
+  }
+
   public fetchTags() {
     return this.http.get<Tag[]>('/api/v1/tags');
   }

libs/ui/src/lib/i18n.ts

@@ -38,9 +38,9 @@ const locales = {
   DIVIDEND: $localize`Dividend`,
   FEE: $localize`Fee`,
   INTEREST: $localize`Interest`,
-  ITEM: $localize`Valuable`,
   LIABILITY: $localize`Liability`,
   SELL: $localize`Sell`,
+  VALUABLE: $localize`Valuable`,
 
   // AssetClass (enum)
   ALTERNATIVE_INVESTMENT: $localize`Alternative Investment`,

package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "ghostfolio",
-  "version": "2.201.0",
+  "version": "2.203.0",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "ghostfolio",
-      "version": "2.201.0",
+      "version": "2.203.0",
       "hasInstallScript": true,
       "license": "AGPL-3.0",
       "dependencies": {
@@ -130,7 +130,7 @@
         "@types/big.js": "6.2.2",
         "@types/google-spreadsheet": "3.1.5",
         "@types/jest": "29.5.13",
-        "@types/lodash": "4.17.17",
+        "@types/lodash": "4.17.20",
         "@types/node": "22.15.17",
         "@types/papaparse": "5.3.7",
         "@types/passport-google-oauth20": "2.0.16",
@@ -14435,9 +14435,9 @@
       }
     },
     "node_modules/@types/lodash": {
-      "version": "4.17.17",
+      "version": "4.17.20",
-      "resolved": "https://registry.npmjs.org/@types/lodash/-/lodash-4.17.17.tgz",
+      "resolved": "https://registry.npmjs.org/@types/lodash/-/lodash-4.17.20.tgz",
-      "integrity": "sha512-RRVJ+J3J+WmyOTqnz3PiBLA501eKwXl2noseKOrNo/6+XEHjTAxO4xHvxQB6QuNm+s4WRbn6rSiap8+EA+ykFQ==",
+      "integrity": "sha512-H3MHACvFUEiujabxhaI/ImO6gUrd8oOurg7LQtS7mbwIXA/cUqWrvBsaeJ23aZEPk1TAYkurjfMbSELfoCXlGA==",
       "dev": true,
       "license": "MIT"
     },

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ghostfolio",
-  "version": "2.201.0",
+  "version": "2.203.0",
   "homepage": "https://ghostfol.io",
   "license": "AGPL-3.0",
   "repository": "https://github.com/ghostfolio/ghostfolio",
@@ -176,7 +176,7 @@
     "@types/big.js": "6.2.2",
     "@types/google-spreadsheet": "3.1.5",
     "@types/jest": "29.5.13",
-    "@types/lodash": "4.17.17",
+    "@types/lodash": "4.17.20",
     "@types/node": "22.15.17",
     "@types/papaparse": "5.3.7",
     "@types/passport-google-oauth20": "2.0.16",

prisma/migrations/20250926182138_removed_item_from_type/migration.sql

@@ -0,0 +1,8 @@
+-- AlterEnum
+BEGIN;
+CREATE TYPE "public"."Type_new" AS ENUM ('BUY', 'DIVIDEND', 'FEE', 'INTEREST', 'LIABILITY', 'SELL');
+ALTER TABLE "public"."Order" ALTER COLUMN "type" TYPE "public"."Type_new" USING ("type"::text::"public"."Type_new");
+ALTER TYPE "public"."Type" RENAME TO "Type_old";
+ALTER TYPE "public"."Type_new" RENAME TO "Type";
+DROP TYPE "public"."Type_old";
+COMMIT;

prisma/schema.prisma

@@ -349,7 +349,6 @@ enum Type {
   DIVIDEND
   FEE
   INTEREST
-  ITEM
   LIABILITY
   SELL
 }

test/import/not-ok/invalid-type-deprecated.json

@@ -1,20 +0,0 @@
-{
-  "meta": {
-    "date": "2023-02-05T00:00:00.000Z",
-    "version": "dev"
-  },
-  "activities": [
-    {
-      "accountId": null,
-      "comment": null,
-      "fee": 0,
-      "quantity": 1,
-      "type": "ITEM",
-      "unitPrice": 500000,
-      "currency": "USD",
-      "dataSource": "MANUAL",
-      "date": "2022-01-01T00:00:00.000Z",
-      "symbol": "Penthouse Apartment"
-    }
-  ]
-}