From cae805bea865070d06e267b9b1de2193aa774cf3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Germ=C3=A1n=20Mart=C3=ADn?= Date: Fri, 10 Oct 2025 00:40:21 +0200 Subject: [PATCH] Refactor ngOnChanges to simplify account assignment logic --- .../src/lib/assistant/assistant.component.ts | 25 +++---------------- 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/libs/ui/src/lib/assistant/assistant.component.ts b/libs/ui/src/lib/assistant/assistant.component.ts index a8d7824c4..343621e99 100644 --- a/libs/ui/src/lib/assistant/assistant.component.ts +++ b/libs/ui/src/lib/assistant/assistant.component.ts @@ -360,27 +360,10 @@ export class GfAssistantComponent implements OnChanges, OnDestroy, OnInit { } public ngOnChanges() { - if (this.accountsWithValue?.length > 0) { - this.accounts = this.accountsWithValue; - } else { - this.accounts = (this.user?.accounts ?? []).map((account) => ({ - ...account, - allocationInPercentage: 0, - balanceInBaseCurrency: account.balance || 0, - dividendInBaseCurrency: 0, - interestInBaseCurrency: 0, - platform: account.platformId - ? { - id: account.platformId, - name: account.platformId, - url: '' - } - : undefined, - transactionCount: 0, - value: account.balance || 0, - valueInBaseCurrency: account.balance || 0 - })) as AccountWithValue[]; - } + this.accounts = (this.user?.accounts ?? []).map((account) => ({ + id: account.id, + name: account.name + })) as AccountWithValue[]; if (this.hasPermissionToChangeFilters) { this.portfolioFilterFormControl.enable({ emitEvent: false });