From cc214f0c7c9ab596957e33c29f0a4f86179b271b Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Mon, 14 Sep 2026 19:48:39 +0200
Subject: [PATCH] Fix coupon validation

---
 .../api/src/app/subscription/subscription.service.ts | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/apps/api/src/app/subscription/subscription.service.ts b/apps/api/src/app/subscription/subscription.service.ts
index 312b8c3aef..f5acbc3e33 100644
--- a/apps/api/src/app/subscription/subscription.service.ts
+++ b/apps/api/src/app/subscription/subscription.service.ts
@@ -58,17 +58,23 @@ export class SubscriptionService {
     } =
       (await this.propertyService.getByKey<any>(PROPERTY_STRIPE_CONFIG)) ?? {};
 
-    const subscriptionOffer = Object.values(subscriptionOffers).find(
+    const subscriptionOffersForPrice = Object.values(subscriptionOffers).filter(
       (subscriptionOffer) => {
         return subscriptionOffer.priceId === priceId;
       }
     );
 
-    if (!subscriptionOffer) {
+    if (subscriptionOffersForPrice.length === 0) {
       throw new BadRequestException('Invalid priceId');
     }
 
-    if (couponId && couponId !== subscriptionOffer.couponId) {
+    const subscriptionOffer = subscriptionOffersForPrice.find(
+      (subscriptionOffer) => {
+        return subscriptionOffer.couponId === couponId;
+      }
+    );
+
+    if (!subscriptionOffer) {
       throw new BadRequestException('Invalid couponId');
     }