From ccf491225a4a9faa66d9f1bb0114a6c844bc9e59 Mon Sep 17 00:00:00 2001 From: Kenrick Tandrian <60643640+KenTandrian@users.noreply.github.com> Date: Wed, 11 Feb 2026 08:09:48 +0000 Subject: [PATCH] fix(lib): remove unused unsubscribe subject as there is no observable subscription --- .../lib/holdings-table/holdings-table.component.ts | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts index 3efe4804c..374fd67a7 100644 --- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts +++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts @@ -11,7 +11,6 @@ import { Component, EventEmitter, Input, - OnDestroy, Output, computed, effect, @@ -25,7 +24,6 @@ import { MatSort, MatSortModule } from '@angular/material/sort'; import { MatTableDataSource, MatTableModule } from '@angular/material/table'; import { AssetSubClass } from '@prisma/client'; import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader'; -import { Subject } from 'rxjs'; import { GfEntityLogoComponent } from '../entity-logo/entity-logo.component'; import { GfValueComponent } from '../value/value.component'; @@ -48,7 +46,7 @@ import { GfValueComponent } from '../value/value.component'; styleUrls: ['./holdings-table.component.scss'], templateUrl: './holdings-table.component.html' }) -export class GfHoldingsTableComponent implements OnDestroy { +export class GfHoldingsTableComponent { @Input() baseCurrency: string; @Input() deviceType: string; @Input() locale = getLocale(); @@ -90,8 +88,6 @@ export class GfHoldingsTableComponent implements OnDestroy { protected readonly isLoading = computed(() => !this.holdings()); - private readonly unsubscribeSubject = new Subject(); - constructor() { this.dataSource.sortingDataAccessor = getLowercase; @@ -120,9 +116,4 @@ export class GfHoldingsTableComponent implements OnDestroy { this.dataSource.paginator = this.paginator(); }); } - - public ngOnDestroy() { - this.unsubscribeSubject.next(); - this.unsubscribeSubject.complete(); - } }