diff --git a/apps/client/src/app/pages/portfolio/holdings/holdings-page.html b/apps/client/src/app/pages/portfolio/holdings/holdings-page.html
index e8bb6eeb3..282dc5a00 100644
--- a/apps/client/src/app/pages/portfolio/holdings/holdings-page.html
+++ b/apps/client/src/app/pages/portfolio/holdings/holdings-page.html
@@ -16,8 +16,8 @@
[baseCurrency]="user?.settings?.baseCurrency"
[deviceType]="deviceType"
[hasPermissionToCreateActivity]="hasPermissionToCreateOrder"
+ [holdings]="holdings"
[locale]="user?.settings?.locale"
- [positions]="holdings"
>
0"
diff --git a/apps/client/src/app/pages/public/public-page.component.ts b/apps/client/src/app/pages/public/public-page.component.ts
index 2238be28b..d9fc411a4 100644
--- a/apps/client/src/app/pages/public/public-page.component.ts
+++ b/apps/client/src/app/pages/public/public-page.component.ts
@@ -28,6 +28,7 @@ export class PublicPageComponent implements OnInit {
[code: string]: { name: string; value: number };
};
public deviceType: string;
+ public holdings: PortfolioPublicDetails['holdings'][string][];
public markets: {
[key in Market]: { name: string; value: number };
};
@@ -37,7 +38,6 @@ export class PublicPageComponent implements OnInit {
value: number;
};
};
- public positionsArray: PortfolioPublicDetails['holdings'][string][];
public sectors: {
[name: string]: { name: string; value: number };
};
@@ -99,6 +99,7 @@ export class PublicPageComponent implements OnInit {
value: 0
}
};
+ this.holdings = [];
this.markets = {
[UNKNOWN_KEY]: {
name: UNKNOWN_KEY,
@@ -118,7 +119,6 @@ export class PublicPageComponent implements OnInit {
}
};
this.positions = {};
- this.positionsArray = [];
this.sectors = {
[UNKNOWN_KEY]: {
name: UNKNOWN_KEY,
@@ -136,14 +136,13 @@ export class PublicPageComponent implements OnInit {
for (const [symbol, position] of Object.entries(
this.portfolioPublicDetails.holdings
)) {
- const value = position.allocationInPercentage;
+ this.holdings.push(position);
this.positions[symbol] = {
- value,
currency: position.currency,
- name: position.name
+ name: position.name,
+ value: position.allocationInPercentage
};
- this.positionsArray.push(position);
if (position.countries.length > 0) {
this.markets.developedMarkets.value +=
diff --git a/apps/client/src/app/pages/public/public-page.html b/apps/client/src/app/pages/public/public-page.html
index d7f73e197..3b39b8f1c 100644
--- a/apps/client/src/app/pages/public/public-page.html
+++ b/apps/client/src/app/pages/public/public-page.html
@@ -133,8 +133,8 @@
diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
index e341e21b2..e931c505e 100644
--- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts
+++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
@@ -1,12 +1,10 @@
import {
ChangeDetectionStrategy,
Component,
- EventEmitter,
Input,
OnChanges,
OnDestroy,
OnInit,
- Output,
ViewChild
} from '@angular/core';
import { MatPaginator } from '@angular/material/paginator';
@@ -14,7 +12,7 @@ import { MatSort } from '@angular/material/sort';
import { MatTableDataSource } from '@angular/material/table';
import { Router } from '@angular/router';
import { PortfolioPosition, UniqueAsset } from '@ghostfolio/common/interfaces';
-import { AssetClass, Order as OrderModel } from '@prisma/client';
+import { AssetClass } from '@prisma/client';
import { Subject, Subscription } from 'rxjs';
@Component({
@@ -28,12 +26,9 @@ export class HoldingsTableComponent implements OnChanges, OnDestroy, OnInit {
@Input() deviceType: string;
@Input() hasPermissionToCreateActivity: boolean;
@Input() hasPermissionToShowValues = true;
+ @Input() holdings: PortfolioPosition[];
@Input() locale: string;
@Input() pageSize = Number.MAX_SAFE_INTEGER;
- @Input() positions: PortfolioPosition[];
-
- @Output() transactionDeleted = new EventEmitter();
- @Output() transactionToUpdate = new EventEmitter();
@ViewChild(MatPaginator) paginator: MatPaginator;
@ViewChild(MatSort) sort: MatSort;
@@ -63,8 +58,8 @@ export class HoldingsTableComponent implements OnChanges, OnDestroy, OnInit {
this.isLoading = true;
- if (this.positions) {
- this.dataSource = new MatTableDataSource(this.positions);
+ if (this.holdings) {
+ this.dataSource = new MatTableDataSource(this.holdings);
this.dataSource.paginator = this.paginator;
this.dataSource.sort = this.sort;