Browse Source

Merge branch 'main' into feature/improve-error-handling-in-data-providers

pull/5387/head
Thomas Kaul 17 hours ago
committed by GitHub
parent
commit
d0db79a887
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 4
      CHANGELOG.md
  2. 2
      apps/api/src/app/admin/admin.controller.ts
  3. 46
      apps/api/src/app/admin/admin.service.ts

4
CHANGELOG.md

@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Unreleased ## Unreleased
### Added
- Extended the data providers management of the admin control panel by every data provider in use
### Changed ### Changed
- Improved the error handling in data providers - Improved the error handling in data providers

2
apps/api/src/app/admin/admin.controller.ts

@ -66,7 +66,7 @@ export class AdminController {
@HasPermission(permissions.accessAdminControl) @HasPermission(permissions.accessAdminControl)
@UseGuards(AuthGuard('jwt'), HasPermissionGuard) @UseGuards(AuthGuard('jwt'), HasPermissionGuard)
public async getAdminData(): Promise<AdminData> { public async getAdminData(): Promise<AdminData> {
return this.adminService.get({ user: this.request.user }); return this.adminService.get();
} }
@Get('demo-user/sync') @Get('demo-user/sync')

46
apps/api/src/app/admin/admin.service.ts

@ -29,7 +29,7 @@ import {
Filter Filter
} from '@ghostfolio/common/interfaces'; } from '@ghostfolio/common/interfaces';
import { Sector } from '@ghostfolio/common/interfaces/sector.interface'; import { Sector } from '@ghostfolio/common/interfaces/sector.interface';
import { MarketDataPreset, UserWithSettings } from '@ghostfolio/common/types'; import { MarketDataPreset } from '@ghostfolio/common/types';
import { import {
BadRequestException, BadRequestException,
@ -133,11 +133,8 @@ export class AdminService {
} }
} }
public async get({ user }: { user: UserWithSettings }): Promise<AdminData> { public async get(): Promise<AdminData> {
const dataSources = await this.dataProviderService.getDataSources({ const dataSources = Object.values(DataSource);
user,
includeGhostfolio: true
});
const [settings, transactionCount, userCount] = await Promise.all([ const [settings, transactionCount, userCount] = await Promise.all([
this.propertyService.get(), this.propertyService.get(),
@ -145,24 +142,31 @@ export class AdminService {
this.countUsersWithAnalytics() this.countUsersWithAnalytics()
]); ]);
const dataProviders = await Promise.all( const dataProviders = (
dataSources.map(async (dataSource) => { await Promise.all(
const dataProviderInfo = this.dataProviderService dataSources.map(async (dataSource) => {
.getDataProvider(dataSource) const assetProfileCount =
.getDataProviderInfo(); await this.prismaService.symbolProfile.count({
where: {
dataSource
}
});
const assetProfileCount = await this.prismaService.symbolProfile.count({ if (assetProfileCount > 0 || dataSource === 'GHOSTFOLIO') {
where: { const dataProviderInfo = this.dataProviderService
dataSource .getDataProvider(dataSource)
.getDataProviderInfo();
return {
...dataProviderInfo,
assetProfileCount
};
} }
});
return { return null;
...dataProviderInfo, })
assetProfileCount )
}; ).filter(Boolean);
})
);
return { return {
dataProviders, dataProviders,

Loading…
Cancel
Save