Optimize stock split activity adjustments

apps/api/src/app/activities/activities.service.spec.ts

@@ -44,7 +44,7 @@ describe('ActivitiesService', () => {
       const result = await getAdjustedActivity(activity, []);
 
       expect(result).toEqual(activity);
-      expect(result).not.toBe(activity);
+      expect(result).toBe(activity);
     });
 
     it.each([

apps/api/src/app/activities/activities.service.ts

@@ -948,18 +948,24 @@ export class ActivitiesService {
         assetProfiles
       );
 
-    activities.activities = activities.activities.map((activity) => {
+    const hasSplits = [...splitsByAssetProfile.values()].some((splits) => {
-      const key = getAssetProfileIdentifier({
+      return splits.length > 0;
-        dataSource: activity.assetProfile.dataSource,
-        symbol: activity.assetProfile.symbol
-      });
-
-      return adjustActivityBySplits(
-        activity,
-        splitsByAssetProfile.get(key) ?? []
-      );
     });
 
+    if (hasSplits) {
+      activities.activities = activities.activities.map((activity) => {
+        const key = getAssetProfileIdentifier({
+          dataSource: activity.assetProfile.dataSource,
+          symbol: activity.assetProfile.symbol
+        });
+
+        return adjustActivityBySplits(
+          activity,
+          splitsByAssetProfile.get(key) ?? []
+        );
+      });
+    }
+
     if (withCash && !this.areCashActivitiesExcludedByFilters(filters)) {
       const cashDetails = await this.accountService.getCashDetails({
         filters,

apps/api/src/services/asset-profile-split/asset-profile-split.helper.spec.ts

@@ -54,9 +54,9 @@ describe('adjustActivityBySplits', () => {
     );
 
     expect(adjustedActivityOnSplitDate).toEqual(activityOnSplitDate);
-    expect(adjustedActivityOnSplitDate).not.toBe(activityOnSplitDate);
+    expect(adjustedActivityOnSplitDate).toBe(activityOnSplitDate);
     expect(adjustedActivityAfterSplit).toEqual(activityAfterSplit);
-    expect(adjustedActivityAfterSplit).not.toBe(activityAfterSplit);
+    expect(adjustedActivityAfterSplit).toBe(activityAfterSplit);
   });
 
   it('compares stored UTC split dates without normalizing them locally', () => {

apps/api/src/services/asset-profile-split/asset-profile-split.helper.ts

@@ -19,7 +19,7 @@ export function adjustActivityBySplits(
   }
 
   if (splitFactor.eq(1)) {
-    return { ...activity };
+    return activity;
   }
 
   return {