From d317e9bada694cc55bf5c1f5ed89b88b3243b8ab Mon Sep 17 00:00:00 2001 From: KenTandrian Date: Mon, 13 Jul 2026 23:38:10 +0700 Subject: [PATCH] feat(ui): implement prefer-nullish-coalescing eslint check --- libs/ui/eslint.config.cjs | 3 ++- libs/ui/src/lib/activities-table/activities-table.component.ts | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libs/ui/eslint.config.cjs b/libs/ui/eslint.config.cjs index e21452b5f..65d17debd 100644 --- a/libs/ui/eslint.config.cjs +++ b/libs/ui/eslint.config.cjs @@ -41,7 +41,8 @@ module.exports = [ } ], '@angular-eslint/prefer-inject': 'off', - '@angular-eslint/prefer-standalone': 'off' + '@angular-eslint/prefer-standalone': 'off', + '@typescript-eslint/prefer-nullish-coalescing': 'error' }, languageOptions: { parserOptions: { diff --git a/libs/ui/src/lib/activities-table/activities-table.component.ts b/libs/ui/src/lib/activities-table/activities-table.component.ts index dd792ca35..9d828d008 100644 --- a/libs/ui/src/lib/activities-table/activities-table.component.ts +++ b/libs/ui/src/lib/activities-table/activities-table.component.ts @@ -267,7 +267,7 @@ export class GfActivitiesTableComponent implements AfterViewInit, OnInit { public isExcludedFromAnalysis(activity: Activity) { return ( - (activity.account && isAccountExcluded(activity.account)) || + (activity.account && isAccountExcluded(activity.account)) ?? activity.tags?.some(({ id }) => { return id === TAG_ID_EXCLUDE_FROM_ANALYSIS; }) === true