From d3a5c64579f0c0f3a87ad974b9d24a6a4b2ac599 Mon Sep 17 00:00:00 2001
From: KenTandrian <kenricktan11@gmail.com>
Date: Sat, 14 Mar 2026 16:52:32 +0700
Subject: [PATCH] feat(lib): resolve type errors in services

---
 libs/ui/src/lib/services/admin.service.ts | 4 ++--
 libs/ui/src/lib/services/data.service.ts  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/libs/ui/src/lib/services/admin.service.ts b/libs/ui/src/lib/services/admin.service.ts
index 145f134e3..7e6e10a38 100644
--- a/libs/ui/src/lib/services/admin.service.ts
+++ b/libs/ui/src/lib/services/admin.service.ts
@@ -132,7 +132,7 @@ export class AdminService {
   public fetchJobs({ status }: { status?: JobStatus[] }) {
     let params = new HttpParams();
 
-    if (status?.length > 0) {
+    if (status && status.length > 0) {
       params = params.append('status', status.join(','));
     }
 
@@ -153,7 +153,7 @@ export class AdminService {
     skip,
     take = DEFAULT_PAGE_SIZE
   }: {
-    skip?: number;
+    skip: number;
     take?: number;
   }) {
     let params = new HttpParams();
diff --git a/libs/ui/src/lib/services/data.service.ts b/libs/ui/src/lib/services/data.service.ts
index 169de067c..2cfb7e30a 100644
--- a/libs/ui/src/lib/services/data.service.ts
+++ b/libs/ui/src/lib/services/data.service.ts
@@ -90,7 +90,7 @@ export class DataService {
   public buildFiltersAsQueryParams({ filters }: { filters?: Filter[] }) {
     let params = new HttpParams();
 
-    if (filters?.length > 0) {
+    if (filters && filters.length > 0) {
       const {
         ACCOUNT: filtersByAccount,
         ASSET_CLASS: filtersByAssetClass,